Commit 8d952504 authored Jan 14, 2010 by James Morris

security: correct error returns for get/set security with private inodes

Currently, the getsecurity and setsecurity operations return zero for
kernel private inodes, where xattrs are not available directly to
userspace.

This confuses some applications, and does not conform to the
man page for getxattr(2) etc., which state that these syscalls
should return ENOTSUP if xattrs are not supported or disabled.

Note that in the listsecurity case, we still need to return zero
as we don't know which other xattr handlers may be active.

For discussion of userland confusion, see:
http://www.mail-archive.com/bug-coreutils@gnu.org/msg17988.html



This patch corrects the error returns so that ENOTSUP is reported
to userspace as required.

Signed-off-by: James Morris <jmorris@namei.org>
Acked-by: Stephen Smalley <sds@tycho.nsa.gov>
Acked-by: Serge Hallyn <serue@us.ibm.com>

parent cd7bec6a

security/security.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -630,14 +630,14 @@ int security_inode_killpriv(struct dentry *dentry)
		int security_inode_getsecurity(const struct inode inode, const char name, void **buffer, bool alloc)
		{
		if (unlikely(IS_PRIVATE(inode)))
		return 0;
		return -EOPNOTSUPP;
		return security_ops->inode_getsecurity(inode, name, buffer, alloc);
		}

		int security_inode_setsecurity(struct inode inode, const char name, const void *value, size_t size, int flags)
		{
		if (unlikely(IS_PRIVATE(inode)))
		return 0;
		return -EOPNOTSUPP;
		return security_ops->inode_setsecurity(inode, name, value, size, flags);
		}

Admin message