Commit 8d76527e authored Jun 04, 2007 by Herbert Xu Committed by David S. Miller Jun 07, 2007

[IPV4]: Only panic if inetdev_init fails for loopback



When I made the inetdev_init call work on all devices I incorrectly
left in the panic call as well.  It is obviously undesirable to
panic on an allocation failure for a normal network device.  This
patch moves the panic call under the loopback if clause.

Signed-off-by: Herbert Xu <herbert@gondor.apana.org.au>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent f0e48dbf

net/ipv4/devinet.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -1057,9 +1057,10 @@ static int inetdev_event(struct notifier_block *this, unsigned long event,
		if (!in_dev) {
		if (event == NETDEV_REGISTER) {
		in_dev = inetdev_init(dev);
		if (!in_dev)
		panic("devinet: Failed to create loopback\n");
		if (dev == &loopback_dev) {
		if (!in_dev)
		panic("devinet: "
		"Failed to create loopback\n");
		in_dev->cnf.no_xfrm = 1;
		in_dev->cnf.no_policy = 1;
		}

Admin message