spi: spi-fsl-lpspi: Fix runtime PM imbalance on error (8d728808) · Commits · 戴 / test

pm_runtime_get_sync() increments the runtime PM usage counter even when it returns an error code. Thus a pairing decrement is needed on the error handling path to keep the counter balanced. Signed-off-by:

Dinghao Liu <dinghao.liu@zju.edu.cn> Link: https://lore.kernel.org/r/20200523133859.5625-1-dinghao.liu@zju.edu.cn Signed-off-by:

Mark Brown <broonie@kernel.org>

drivers/spi/spi-fsl-lpspi.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -940,7 +940,7 @@ static int fsl_lpspi_probe(struct platform_device *pdev)
		ret = pm_runtime_get_sync(fsl_lpspi->dev);
		if (ret < 0) {
		dev_err(fsl_lpspi->dev, "failed to enable clock\n");
		goto out_controller_put;
		goto out_pm_get;
		}

		temp = readl(fsl_lpspi->base + IMX7ULP_PARAM);
		@@ -949,13 +949,15 @@ static int fsl_lpspi_probe(struct platform_device *pdev)

		ret = fsl_lpspi_dma_init(&pdev->dev, fsl_lpspi, controller);
		if (ret == -EPROBE_DEFER)
		goto out_controller_put;
		goto out_pm_get;

		if (ret < 0)
		dev_err(&pdev->dev, "dma setup error %d, use pio\n", ret);

		return 0;

		out_pm_get:
		pm_runtime_put_noidle(fsl_lpspi->dev);
		out_controller_put:
		spi_controller_put(controller);

Admin message