Commit 8d726c51 authored Dec 26, 2018 by Yangtao Li Committed by Stephen Boyd Dec 28, 2018

clk: dove: fix refcount leak in dove_clk_init()

The of_find_compatible_node() returns a node pointer with refcount
incremented, but there is the lack of use of the of_node_put() when
done. Add the missing of_node_put() to release the refcount.

Signed-off-by: Yangtao Li <tiny.windzz@gmail.com>
Reviewed-by: Gregory CLEMENT <gregory.clement@bootlin.com>
Fixes: 8f7fc545 ("clk: mvebu: dove: maintain clock init order")
Fixes: 63b8d92c ("clk: add Dove PLL divider support for GPU, VMeta and AXI clocks")
Signed-off-by: Stephen Boyd <sboyd@kernel.org>

parent 9b4eedf6

drivers/clk/mvebu/dove.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -188,10 +188,14 @@ static void __init dove_clk_init(struct device_node *np)

		mvebu_coreclk_setup(np, &dove_coreclks);

		if (ddnp)
		if (ddnp) {
		dove_divider_clk_init(ddnp);
		of_node_put(ddnp);
		}

		if (cgnp)
		if (cgnp) {
		mvebu_clk_gating_setup(cgnp, dove_gating_desc);
		of_node_put(cgnp);
		}
		}
		CLK_OF_DECLARE(dove_clk, "marvell,dove-core-clock", dove_clk_init);

Admin message