efi/gop: Remove bogus packed attribute from GOP structures (8d62af17) · Commits · 戴 / test

EFI structures are not packed, they follow natural alignment. The packed attribute doesn't have any effect on the structure layout due to the types and order of the members, and we only ever get these structures as output from the EFI firmware so alignment issues have not come up. Signed-off-by:

Arvind Sankar <nivedita@alum.mit.edu> Signed-off-by:

Ard Biesheuvel <ardb@kernel.org> Cc: Borislav Petkov <bp@alien8.de> Cc: James Morse <james.morse@arm.com> Cc: Matt Fleming <matt@codeblueprint.co.uk> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: linux-efi@vger.kernel.org Link: https://lkml.kernel.org/r/20191224151025.32482-2-ardb@kernel.org Signed-off-by:

Ingo Molnar <mingo@kernel.org>

include/linux/efi.h

+4 −4

Original line number	Diff line number	Diff line
		@@ -1429,7 +1429,7 @@ struct efi_graphics_output_mode_info {
		int pixel_format;
		struct efi_pixel_bitmask pixel_information;
		u32 pixels_per_scan_line;
		} __packed;
		};

		struct efi_graphics_output_protocol_mode_32 {
		u32 max_mode;
		@@ -1438,7 +1438,7 @@ struct efi_graphics_output_protocol_mode_32 {
		u32 size_of_info;
		u64 frame_buffer_base;
		u32 frame_buffer_size;
		} __packed;
		};

		struct efi_graphics_output_protocol_mode_64 {
		u32 max_mode;
		@@ -1447,7 +1447,7 @@ struct efi_graphics_output_protocol_mode_64 {
		u64 size_of_info;
		u64 frame_buffer_base;
		u64 frame_buffer_size;
		} __packed;
		};

		struct efi_graphics_output_protocol_mode {
		u32 max_mode;
		@@ -1456,7 +1456,7 @@ struct efi_graphics_output_protocol_mode {
		unsigned long size_of_info;
		u64 frame_buffer_base;
		unsigned long frame_buffer_size;
		} __packed;
		};

		struct efi_graphics_output_protocol_32 {
		u32 query_mode;

Admin message