Commit 8d5d0cfb authored by Quentin Perret's avatar Quentin Perret Committed by Ingo Molnar
Browse files

sched/topology: Introduce a sysctl for Energy Aware Scheduling 



In its current state, Energy Aware Scheduling (EAS) starts automatically
on asymmetric platforms having an Energy Model (EM). However, there are
users who want to have an EM (for thermal management for example), but
don't want EAS with it.

In order to let users disable EAS explicitly, introduce a new sysctl
called 'sched_energy_aware'. It is enabled by default so that EAS can
start automatically on platforms where it makes sense. Flipping it to 0
rebuilds the scheduling domains and disables EAS.

Signed-off-by: default avatarQuentin Perret <quentin.perret@arm.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: adharmap@codeaurora.org
Cc: chris.redpath@arm.com
Cc: currojerez@riseup.net
Cc: dietmar.eggemann@arm.com
Cc: edubezval@gmail.com
Cc: gregkh@linuxfoundation.org
Cc: javi.merino@kernel.org
Cc: joel@joelfernandes.org
Cc: juri.lelli@redhat.com
Cc: morten.rasmussen@arm.com
Cc: patrick.bellasi@arm.com
Cc: pkondeti@codeaurora.org
Cc: rjw@rjwysocki.net
Cc: skannan@codeaurora.org
Cc: smuckle@google.com
Cc: srinivas.pandruvada@linux.intel.com
Cc: thara.gopinath@linaro.org
Cc: tkjos@google.com
Cc: valentin.schneider@arm.com
Cc: vincent.guittot@linaro.org
Cc: viresh.kumar@linaro.org
Link: https://lkml.kernel.org/r/20181203095628.11858-11-quentin.perret@arm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 62a8ddc9

Documentation/sysctl/kernel.txt

+12 −0
Original line number Diff line number Diff line
@@ -79,6 +79,7 @@ show up in /proc/sys/kernel: 
- reboot-cmd                  [ SPARC only ]

- rtsig-max

- rtsig-nr

- sched_energy_aware

- seccomp/                    ==> Documentation/userspace-api/seccomp_filter.rst

- sem

- sem_next_id		      [ sysv ipc ]
@@ -890,6 +891,17 @@ rtsig-nr shows the number of RT signals currently queued. 


==============================================================



sched_energy_aware:



Enables/disables Energy Aware Scheduling (EAS). EAS starts

automatically on platforms where it can run (that is,

platforms with asymmetric CPU topologies and having an Energy

Model available). If your platform happens to meet the

requirements for EAS but you do not want to use it, change

this value to 0.



==============================================================



sched_schedstats:



Enables/disables scheduler statistics. Enabling this feature

include/linux/sched/sysctl.h

+7 −0
Original line number Diff line number Diff line
@@ -83,4 +83,11 @@ extern int sysctl_schedstats(struct ctl_table *table, int write, 
				 void __user *buffer, size_t *lenp,

				 loff_t *ppos);



#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)

extern unsigned int sysctl_sched_energy_aware;

extern int sched_energy_aware_handler(struct ctl_table *table, int write,

				 void __user *buffer, size_t *lenp,

				 loff_t *ppos);

#endif



#endif /* _LINUX_SCHED_SYSCTL_H */

kernel/sched/topology.c

+29 −0
Original line number Diff line number Diff line
@@ -203,9 +203,35 @@ sd_parent_degenerate(struct sched_domain *sd, struct sched_domain *parent) 


DEFINE_STATIC_KEY_FALSE(sched_energy_present);

#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)

unsigned int sysctl_sched_energy_aware = 1;

DEFINE_MUTEX(sched_energy_mutex);

bool sched_energy_update;



#ifdef CONFIG_PROC_SYSCTL

int sched_energy_aware_handler(struct ctl_table *table, int write,

			 void __user *buffer, size_t *lenp, loff_t *ppos)

{

	int ret, state;



	if (write && !capable(CAP_SYS_ADMIN))

		return -EPERM;



	ret = proc_dointvec_minmax(table, write, buffer, lenp, ppos);

	if (!ret && write) {

		state = static_branch_unlikely(&sched_energy_present);

		if (state != sysctl_sched_energy_aware) {

			mutex_lock(&sched_energy_mutex);

			sched_energy_update = 1;

			rebuild_sched_domains();

			sched_energy_update = 0;

			mutex_unlock(&sched_energy_mutex);

		}

	}



	return ret;

}

#endif



static void free_pd(struct perf_domain *pd)

{

	struct perf_domain *tmp;
@@ -322,6 +348,9 @@ static bool build_perf_domains(const struct cpumask *cpu_map) 
	struct cpufreq_policy *policy;

	struct cpufreq_governor *gov;



	if (!sysctl_sched_energy_aware)

		goto free;



	/* EAS is enabled for asymmetric CPU capacity topologies. */

	if (!per_cpu(sd_asym_cpucapacity, cpu)) {

		if (sched_debug()) {

kernel/sysctl.c

+11 −0
Original line number Diff line number Diff line
@@ -467,6 +467,17 @@ static struct ctl_table kern_table[] = { 
		.extra1		= &one,

	},

#endif

#if defined(CONFIG_ENERGY_MODEL) && defined(CONFIG_CPU_FREQ_GOV_SCHEDUTIL)

	{

		.procname	= "sched_energy_aware",

		.data		= &sysctl_sched_energy_aware,

		.maxlen		= sizeof(unsigned int),

		.mode		= 0644,

		.proc_handler	= sched_energy_aware_handler,

		.extra1		= &zero,

		.extra2		= &one,

	},

#endif

#ifdef CONFIG_PROVE_LOCKING

	{

		.procname	= "prove_locking",

CRA Git | Maintained and supported by SUSTech CRA and CCSE