Commit 8d4c277e authored Mar 01, 2013 by Jon Hunter Committed by Grant Likely Mar 06, 2013

gpio/omap: warn if bank is not enabled on setting irq type



For OMAP devices, if a gpio is being used as an interrupt source but has
not been requested by calling gpio_request(), a call to request_irq()
may cause the kernel hang because the gpio bank may be disabled and
hence the register access will fail. To prevent such hangs, test for
this case and warn if this is detected.

Signed-off-by: Jon Hunter <jon-hunter@ti.com>
Reviewed-by: Felipe Balbi <balbi@ti.com>
Acked-by: Santosh Shilimkar <santosh.shilimkar@ti.com>
Acked-by: Kevin Hilman <khilman@linaro.org>
Tested-by: Javier Martinez Canillas <javier@dowhile0.org>
Signed-off-by: Grant Likely <grant.likely@secretlab.ca>

parent ede4d7a5

drivers/gpio/gpio-omap.c

+3 −0

Original line number	Diff line number	Diff line
		@@ -427,6 +427,9 @@ static int gpio_irq_type(struct irq_data *d, unsigned type)
		int retval;
		unsigned long flags;

		if (WARN_ON(!bank->mod_usage))
		return -EINVAL;

		#ifdef CONFIG_ARCH_OMAP1
		if (d->irq > IH_MPUIO_BASE)
		gpio = OMAP_MPUIO(d->irq - IH_MPUIO_BASE);

Admin message