Commit 8d3d7c20 authored Sep 18, 2019 by Bjørn Mork Committed by Jakub Kicinski Sep 21, 2019

usbnet: ignore endpoints with invalid wMaxPacketSize



Endpoints with zero wMaxPacketSize are not usable for transferring
data. Ignore such endpoints when looking for valid in, out and
status pipes, to make the drivers more robust against invalid and
meaningless descriptors.

The wMaxPacketSize of these endpoints are used for memory allocations
and as divisors in many usbnet minidrivers. Avoiding zero is therefore
critical.

Signed-off-by: Bjørn Mork <bjorn@mork.no>
Signed-off-by: Jakub Kicinski <jakub.kicinski@netronome.com>

parent 3fe4b335

drivers/net/usb/usbnet.c

+5 −0

Original line number	Diff line number	Diff line
		@@ -100,6 +100,11 @@ int usbnet_get_endpoints(struct usbnet dev, struct usb_interface intf)
		int intr = 0;

		e = alt->endpoint + ep;

		/* ignore endpoints which cannot transfer data */
		if (!usb_endpoint_maxp(&e->desc))
		continue;

		switch (e->desc.bmAttributes) {
		case USB_ENDPOINT_XFER_INT:
		if (!usb_endpoint_dir_in(&e->desc))

Admin message