Commit 8d325880 authored by Mark Rutland's avatar Mark Rutland Committed by Ingo Molnar
Browse files

locking/atomics: Check generated headers are up-to-date 



Now that all the generated atomic headers are in place, it would be good
to ensure that:

a) the headers are up-to-date when scripting changes.

b) developers don't directly modify the generated headers.

To ensure both of these properties, let's add a Kbuild step to check
that the generated headers are up-to-date.

Signed-off-by: default avatarMark Rutland <mark.rutland@arm.com>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: linux-arm-kernel@lists.infradead.org
Cc: catalin.marinas@arm.com
Cc: Will Deacon <will.deacon@arm.com>
Cc: linuxdrivers@attotech.com
Cc: dvyukov@google.com
Cc: Boqun Feng <boqun.feng@gmail.com>
Cc: arnd@arndb.de
Cc: aryabinin@virtuozzo.com
Cc: glider@google.com
Link: http://lkml.kernel.org/r/20180904104830.2975-6-mark.rutland@arm.com


Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent aa525d06

Kbuild

+16 −2
Original line number Diff line number Diff line
@@ -6,7 +6,8 @@ 
# 2) Generate timeconst.h

# 3) Generate asm-offsets.h (may need bounds.h and timeconst.h)

# 4) Check for missing system calls

# 5) Generate constants.py (may need bounds.h)

# 5) check atomics headers are up-to-date

# 6) Generate constants.py (may need bounds.h)



#####

# 1) Generate bounds.h
@@ -72,7 +73,20 @@ missing-syscalls: scripts/checksyscalls.sh $(offsets-file) FORCE 
	$(call cmd,syscalls)



#####

# 5) Generate constants for Python GDB integration

# 5) Check atomic headers are up-to-date

#



always += old-atomics

targets += old-atomics



quiet_cmd_atomics = CALL    $<

      cmd_atomics = $(CONFIG_SHELL) scripts/atomic/check-atomics.sh



old-atomics: scripts/atomic/check-atomics.sh FORCE

	$(call cmd,atomics)



#####

# 6) Generate constants for Python GDB integration

#



extra-$(CONFIG_GDB_SCRIPTS) += build_constants_py

scripts/atomic/check-atomics.sh

0 → 100644
+19 −0
Original line number Diff line number Diff line 
#!/bin/sh

# SPDX-License-Identifier: GPL-2.0

#

# Check if atomic headers are up-to-date



ATOMICDIR=$(dirname $0)

ATOMICTBL=${ATOMICDIR}/atomics.tbl

LINUXDIR=${ATOMICDIR}/../..



cat <<EOF |

gen-atomic-instrumented.sh      asm-generic/atomic-instrumented.h

gen-atomic-long.sh              asm-generic/atomic-long.h

gen-atomic-fallback.sh          linux/atomic-fallback.h

EOF

while read script header; do

	if ! (${ATOMICDIR}/${script} ${ATOMICTBL} | diff - ${LINUXDIR}/include/${header} > /dev/null); then

		printf "warning: include/${header} is out-of-date.\n"

	fi

done

CRA Git | Maintained and supported by SUSTech CRA and CCSE