Commit 8d1a7aae authored Dec 05, 2019 by Madhuparna Bhowmik Committed by David Sterba Oct 07, 2020

btrfs: annotate device name rcu_string with __rcu



This patch fixes the following sparse errors in
fs/btrfs/super.c in function btrfs_show_devname()

  fs/btrfs/super.c: error: incompatible types in comparison expression (different address spaces):
  fs/btrfs/super.c:    struct rcu_string [noderef] <asn:4> *
  fs/btrfs/super.c:    struct rcu_string *

The error was because of the following line in function btrfs_show_devname():

  if (first_dev)
	 seq_escape(m, rcu_str_deref(first_dev->name), " \t\n\\");

Annotating the btrfs_device::name member with __rcu fixes the sparse
error.

Acked-by: Joel Fernandes (Google) <joel@joelfernandes.org>
Signed-off-by: Madhuparna Bhowmik <madhuparnabhowmik04@gmail.com>
Signed-off-by: David Sterba <dsterba@suse.com>

parent 96c2e067

fs/btrfs/volumes.h

+1 −1

Original line number	Diff line number	Diff line
		@@ -58,7 +58,7 @@ struct btrfs_device {
		struct btrfs_fs_devices *fs_devices;
		struct btrfs_fs_info *fs_info;

		struct rcu_string *name;
		struct rcu_string __rcu *name;

		u64 generation;

Admin message