Commit 8d143c61 authored Nov 30, 2020 by Lukas Bulwahn Committed by Petr Mladek Dec 08, 2020

printk: remove obsolete dead assignment

Commit 849f3127 ("switch /dev/kmsg to ->write_iter()") refactored
devkmsg_write() and left over a dead assignment on the variable 'len'.

Hence, make clang-analyzer warns:

  kernel/printk/printk.c:744:4: warning: Value stored to 'len' is never read
    [clang-analyzer-deadcode.DeadStores]
                          len -= endp - line;
                          ^

Simply remove this obsolete dead assignment here.

Link: https://lore.kernel.org/r/20201130124915.7573-1-lukas.bulwahn@gmail.com


Signed-off-by: Lukas Bulwahn <lukas.bulwahn@gmail.com>
Reviewed-by: Sergey Senozhatsky <sergey.senozhatsky@gmail.com>
Reviewed-by: Petr Mladek <pmladek@suse.com>
Signed-off-by: Petr Mladek <pmladek@suse.com>

parent 584da076

kernel/printk/printk.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -741,7 +741,6 @@ static ssize_t devkmsg_write(struct kiocb iocb, struct iov_iter from)
		if (LOG_FACILITY(u) != 0)
		facility = LOG_FACILITY(u);
		endp++;
		len -= endp - line;
		line = endp;
		}
		}

Admin message