Commit 8cff43d4 authored by Douglas Anderson's avatar Douglas Anderson Committed by Stephen Boyd
Browse files

dt-bindings: clock: Cleanup qcom,videocc bindings for sdm845/sc7180 



This makes the qcom,videocc bindings match the recent changes to the
dispcc and gpucc.

1. Switched to using "bi_tcxo" instead of "xo".

2. Adds a description for the XO clock.  Not terribly important but
   nice if it cleanly matches its cousins.

3. Updates the example to use the symbolic name for the RPMH clock and
   also show that the real devices are currently using 2 address cells
   / size cells and fixes the spacing on the closing brace.

4. Split into 2 files.  In this case they could probably share one
   file, but let's be consistent.

Signed-off-by: default avatarDouglas Anderson <dianders@chromium.org>
Link: https://lkml.kernel.org/r/20200203103049.v4.11.I27bbd90045f38cd3218c259526409d52a48efb35@changeid


Signed-off-by: default avatarStephen Boyd <sboyd@kernel.org>
parent 72de7a19

Documentation/devicetree/bindings/clock/qcom,sc7180-videocc.yaml

0 → 100644
+63 −0
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

%YAML 1.2

---

$id: http://devicetree.org/schemas/clock/qcom,sc7180-videocc.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Qualcomm Video Clock & Reset Controller Binding for SC7180



maintainers:

  - Taniya Das <tdas@codeaurora.org>



description: |

  Qualcomm video clock control module which supports the clocks, resets and

  power domains on SC7180.



  See also dt-bindings/clock/qcom,videocc-sc7180.h.



properties:

  compatible:

    const: qcom,sc7180-videocc



  clocks:

    items:

      - description: Board XO source



  clock-names:

    items:

      - const: bi_tcxo



  '#clock-cells':

    const: 1



  '#reset-cells':

    const: 1



  '#power-domain-cells':

    const: 1



  reg:

    maxItems: 1



required:

  - compatible

  - reg

  - clocks

  - clock-names

  - '#clock-cells'

  - '#reset-cells'

  - '#power-domain-cells'



examples:

  - |

    #include <dt-bindings/clock/qcom,rpmh.h>

    clock-controller@ab00000 {

      compatible = "qcom,sc7180-videocc";

      reg = <0 0x0ab00000 0 0x10000>;

      clocks = <&rpmhcc RPMH_CXO_CLK>;

      clock-names = "bi_tcxo";

      #clock-cells = <1>;

      #reset-cells = <1>;

      #power-domain-cells = <1>;

    };

...

Documentation/devicetree/bindings/clock/qcom,videocc.yaml→Documentation/devicetree/bindings/clock/qcom,sdm845-videocc.yaml

+14 −13
Original line number Diff line number Diff line 
# SPDX-License-Identifier: GPL-2.0-only

%YAML 1.2

---

$id: http://devicetree.org/schemas/bindings/clock/qcom,videocc.yaml#

$id: http://devicetree.org/schemas/clock/qcom,sdm845-videocc.yaml#

$schema: http://devicetree.org/meta-schemas/core.yaml#



title: Qualcomm Video Clock & Reset Controller Binding

title: Qualcomm Video Clock & Reset Controller Binding for SDM845



maintainers:

  - Taniya Das <tdas@codeaurora.org>



description: |

  Qualcomm video clock control module which supports the clocks, resets and

  power domains.

  power domains on SDM845.



  See also dt-bindings/clock/qcom,videocc-sdm845.h.



properties:

  compatible:

    enum:

      - qcom,sc7180-videocc

      - qcom,sdm845-videocc

    const: qcom,sdm845-videocc



  clocks:

    maxItems: 1

    items:

      - description: Board XO source



  clock-names:

    items:

      - const: xo

      - const: bi_tcxo



  '#clock-cells':

    const: 1
@@ -48,13 +49,13 @@ required: 
  - '#power-domain-cells'



examples:

  # Example of VIDEOCC with clock node properties for SDM845:

  - |

    #include <dt-bindings/clock/qcom,rpmh.h>

    clock-controller@ab00000 {

      compatible = "qcom,sdm845-videocc";

      reg = <0xab00000 0x10000>;

      clocks = <&rpmhcc 0>;

      clock-names = "xo";

      reg = <0 0x0ab00000 0 0x10000>;

      clocks = <&rpmhcc RPMH_CXO_CLK>;

      clock-names = "bi_tcxo";

      #clock-cells = <1>;

      #reset-cells = <1>;

      #power-domain-cells = <1>;

CRA Git | Maintained and supported by SUSTech CRA and CCSE