Commit 8cfd4f5d authored by Noralf Trønnes's avatar Noralf Trønnes
Browse files

drm/rockchip: Use .dumb_map_offset and .dumb_destroy defaults 



This driver can use the drm_driver.dumb_destroy and
drm_driver.dumb_map_offset defaults, so no need to set them.

Cc: Mark Yao <mark.yao@rock-chips.com>
Signed-off-by: default avatarNoralf Trønnes <noralf@tronnes.org>
Reviewed-by: default avatarSean Paul <seanpaul@chromium.org>
Link: https://patchwork.freedesktop.org/patch/msgid/1500837417-40580-25-git-send-email-noralf@tronnes.org
parent 819e0a98

drivers/gpu/drm/rockchip/rockchip_drm_drv.c

+0 −2
Original line number Diff line number Diff line
@@ -233,8 +233,6 @@ static struct drm_driver rockchip_drm_driver = { 
	.gem_vm_ops		= &drm_gem_cma_vm_ops,

	.gem_free_object_unlocked = rockchip_gem_free_object,

	.dumb_create		= rockchip_gem_dumb_create,

	.dumb_map_offset	= rockchip_gem_dumb_map_offset,

	.dumb_destroy		= drm_gem_dumb_destroy,

	.prime_handle_to_fd	= drm_gem_prime_handle_to_fd,

	.prime_fd_to_handle	= drm_gem_prime_fd_to_handle,

	.gem_prime_import	= drm_gem_prime_import,

drivers/gpu/drm/rockchip/rockchip_drm_gem.c

+0 −26
Original line number Diff line number Diff line
@@ -393,32 +393,6 @@ err_handle_create: 
	return ERR_PTR(ret);

}



int rockchip_gem_dumb_map_offset(struct drm_file *file_priv,

				 struct drm_device *dev, uint32_t handle,

				 uint64_t *offset)

{

	struct drm_gem_object *obj;

	int ret;



	obj = drm_gem_object_lookup(file_priv, handle);

	if (!obj) {

		DRM_ERROR("failed to lookup gem object.\n");

		return -EINVAL;

	}



	ret = drm_gem_create_mmap_offset(obj);

	if (ret)

		goto out;



	*offset = drm_vma_node_offset_addr(&obj->vma_node);

	DRM_DEBUG_KMS("offset = 0x%llx\n", *offset);



out:

	drm_gem_object_unreference_unlocked(obj);



	return 0;

}



/*

 * rockchip_gem_dumb_create - (struct drm_driver)->dumb_create callback

 * function

drivers/gpu/drm/rockchip/rockchip_drm_gem.h

+0 −3
Original line number Diff line number Diff line
@@ -57,7 +57,4 @@ void rockchip_gem_free_object(struct drm_gem_object *obj); 
int rockchip_gem_dumb_create(struct drm_file *file_priv,

			     struct drm_device *dev,

			     struct drm_mode_create_dumb *args);

int rockchip_gem_dumb_map_offset(struct drm_file *file_priv,

				 struct drm_device *dev, uint32_t handle,

				 uint64_t *offset);

#endif /* _ROCKCHIP_DRM_GEM_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE