Commit 8cc1da96 authored by Ben Dooks's avatar Ben Dooks Committed by David S. Miller
Browse files

net: cdc_ncm: use tasklet_init() for tasklet_struct init 



The tasklet initialisation would be better done by tasklet_init()
instead of assuming all the fields are in an ok state by default.

This does not fix any actual know bug.

Signed-off-by: default avatarBen Dooks <ben.dooks@codethink.co.uk>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9dffa76c

drivers/net/usb/cdc_ncm.c

+1 −2
Original line number Original line Diff line number Diff line
@@ -779,8 +779,7 @@ int cdc_ncm_bind_common(struct usbnet *dev, struct usb_interface *intf, u8 data_ 




	hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);

	hrtimer_init(&ctx->tx_timer, CLOCK_MONOTONIC, HRTIMER_MODE_REL);

	ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;

	ctx->tx_timer.function = &cdc_ncm_tx_timer_cb;

	ctx->bh.data = (unsigned long)dev;

	tasklet_init(&ctx->bh, cdc_ncm_txpath_bh, (unsigned long)dev);

	ctx->bh.func = cdc_ncm_txpath_bh;

	atomic_set(&ctx->stop, 0);

	atomic_set(&ctx->stop, 0);

	spin_lock_init(&ctx->mtx);

	spin_lock_init(&ctx->mtx);

CRA Git | Maintained and supported by SUSTech CRA and CCSE