hwmon: (lm75) Fix all coding-style warnings on lm75 driver (8cbf2172) · Commits · 戴 / test

drivers/hwmon/lm75.c

+6 −2

Original line number	Diff line number	Diff line
		@@ -797,8 +797,10 @@ static int lm75_detect(struct i2c_client *new_client,

		/* First check for LM75A */
		if (i2c_smbus_read_byte_data(new_client, 7) == LM75A_ID) {
		/* LM75A returns 0xff on unused registers so
		just to be sure we check for that too. */
		/*
		* LM75A returns 0xff on unused registers so
		* just to be sure we check for that too.
		*/
		if (i2c_smbus_read_byte_data(new_client, 4) != 0xff
		\|\| i2c_smbus_read_byte_data(new_client, 5) != 0xff
		\|\| i2c_smbus_read_byte_data(new_client, 6) != 0xff)
		@@ -849,6 +851,7 @@ static int lm75_suspend(struct device *dev)
		{
		int status;
		struct i2c_client *client = to_i2c_client(dev);

		status = i2c_smbus_read_byte_data(client, LM75_REG_CONF);
		if (status < 0) {
		dev_dbg(&client->dev, "Can't read config? %d\n", status);
		@@ -863,6 +866,7 @@ static int lm75_resume(struct device *dev)
		{
		int status;
		struct i2c_client *client = to_i2c_client(dev);

		status = i2c_smbus_read_byte_data(client, LM75_REG_CONF);
		if (status < 0) {
		dev_dbg(&client->dev, "Can't read config? %d\n", status);

drivers/hwmon/lm75.h

+17 −14

Original line number	Diff line number	Diff line
		/* SPDX-License-Identifier: GPL-2.0-or-later */
		/*
		lm75.h - Part of lm_sensors, Linux kernel modules for hardware
		monitoring
		Copyright (c) 2003 Mark M. Hoffman <mhoffman@lightlink.com>

		* lm75.h - Part of lm_sensors, Linux kernel modules for hardware monitoring
		* Copyright (c) 2003 Mark M. Hoffman <mhoffman@lightlink.com>
		*/

		/*
		This file contains common code for encoding/decoding LM75 type
		temperature readings, which are emulated by many of the chips
		we support. As the user is unlikely to load more than one driver
		which contains this code, we don't worry about the wasted space.
		* This file contains common code for encoding/decoding LM75 type
		* temperature readings, which are emulated by many of the chips
		* we support. As the user is unlikely to load more than one driver
		* which contains this code, we don't worry about the wasted space.
		*/

		#include <linux/kernel.h>
		@@ -20,18 +18,23 @@
		#define LM75_TEMP_MAX 125000
		#define LM75_SHUTDOWN 0x01

		/* TEMP: 0.001C/bit (-55C to +125C)
		REG: (0.5C/bit, two's complement) << 7 */
		/*
		* TEMP: 0.001C/bit (-55C to +125C)
		* REG: (0.5C/bit, two's complement) << 7
		*/
		static inline u16 LM75_TEMP_TO_REG(long temp)
		{
		int ntemp = clamp_val(temp, LM75_TEMP_MIN, LM75_TEMP_MAX);

		ntemp += (ntemp < 0 ? -250 : 250);
		return (u16)((ntemp / 500) << 7);
		}

		static inline int LM75_TEMP_FROM_REG(u16 reg)
		{
		/* use integer division instead of equivalent right shift to
		guarantee arithmetic shift and preserve the sign */
		/*
		* use integer division instead of equivalent right shift to
		* guarantee arithmetic shift and preserve the sign
		*/
		return ((s16)reg / 128) * 500;
		}

Admin message