checkpatch: Remove ACCESS_ONCE() warning (8cb562b1) · Commits · 戴 / test

Now that ACCESS_ONCE() has been excised from the kernel, any uses will result in a build error, and we no longer need to whine about it in checkpatch. This patch removes the newly redundant warning. Tested-by:

Paul E. McKenney <paulmck@linux.vnet.ibm.com> Signed-off-by:

Mark Rutland <mark.rutland@arm.com> Acked-by:

Joe Perches <joe@perches.com> Cc: Andy Whitcroft <apw@canonical.com> Cc: Linus Torvalds <torvalds@linux-foundation.org> Cc: Peter Zijlstra <peterz@infradead.org> Cc: Thomas Gleixner <tglx@linutronix.de> Cc: acme@redhat.com Link: http://lkml.kernel.org/r/20171127103824.36526-5-mark.rutland@arm.com Signed-off-by:

Ingo Molnar <mingo@kernel.org>

scripts/checkpatch.pl

+0 −22

Original line number	Diff line number	Diff line
		@@ -6233,28 +6233,6 @@ sub process {
		}
		}

		# whine about ACCESS_ONCE
		if ($^V && $^V ge 5.10.0 &&
		$line =~ /\bACCESS_ONCE\s$balanced_parens\s(=(?!=))?\s*($FuncArg)?/) {
		my $par = $1;
		my $eq = $2;
		my $fun = $3;
		$par =~ s/^$\s(.)\s*$$/$1/;
		if (defined($eq)) {
		if (WARN("PREFER_WRITE_ONCE",
		"Prefer WRITE_ONCE(<FOO>, <BAR>) over ACCESS_ONCE(<FOO>) = <BAR>\n" . $herecurr) &&
		$fix) {
		$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s$\s\Q$par\E\s$\s$eq\s*\Q$fun\E/WRITE_ONCE($par, $fun)/;
		}
		} else {
		if (WARN("PREFER_READ_ONCE",
		"Prefer READ_ONCE(<FOO>) over ACCESS_ONCE(<FOO>)\n" . $herecurr) &&
		$fix) {
		$fixed[$fixlinenr] =~ s/\bACCESS_ONCE\s$\s\Q$par\E\s*$/READ_ONCE($par)/;
		}
		}
		}

		# check for mutex_trylock_recursive usage
		if ($line =~ /mutex_trylock_recursive/) {
		ERROR("LOCKING",

Admin message