Commit 8caf92d8 authored Jul 12, 2014 by K. Y. Srinivasan Committed by Christoph Hellwig Jul 25, 2014

Drivers: scsi: storvsc: Filter commands based on the storage protocol version



Going forward it is possible that some of the commands that are not currently
implemented will be implemented on future Windows hosts. Even if they are not
implemented, we are told the host will corrrectly handle unsupported
commands (by returning appropriate return code and sense information).
Make command filtering depend on the host version.

Signed-off-by: K. Y. Srinivasan <kys@microsoft.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Cc: <stable@vger.kernel.org>
Signed-off-by: Christoph Hellwig <hch@lst.de>

parent 52f9614d

drivers/scsi/storvsc_drv.c

+13 −3

Original line number	Diff line number	Diff line
		@@ -1553,10 +1553,20 @@ static int storvsc_queuecommand(struct Scsi_Host host, struct scsi_cmnd scmnd)
		struct vmscsi_request *vm_srb;
		struct stor_mem_pools *memp = scmnd->device->hostdata;

		if (vmstor_current_major <= VMSTOR_WIN8_MAJOR) {
		/*
		* On legacy hosts filter unimplemented commands.
		* Future hosts are expected to correctly handle
		* unsupported commands. Furthermore, it is
		* possible that some of the currently
		* unsupported commands maybe supported in
		* future versions of the host.
		*/
		if (!storvsc_scsi_cmd_ok(scmnd)) {
		scmnd->scsi_done(scmnd);
		return 0;
		}
		}

		request_size = sizeof(struct storvsc_cmd_request);

Admin message