Commit 8c9620b1 authored Jan 19, 2019 by Lukas Wunner Committed by Ulf Hansson Jan 28, 2019

mmc: bcm2835: Fix DMA channel leak on probe error



The BCM2835 MMC host driver requests a DMA channel on probe but neglects
to release the channel in the probe error path.  The channel may
therefore be leaked, in particular if devm_clk_get() causes probe
deferral.  Fix it.

Fixes: 660fc733 ("mmc: bcm2835: Add new driver for the sdhost controller.")
Signed-off-by: Lukas Wunner <lukas@wunner.de>
Cc: stable@vger.kernel.org # v4.12+
Cc: Frank Pavlic <f.pavlic@kunbus.de>
Tested-by: Stefan Wahren <stefan.wahren@i2se.com>
Signed-off-by: Ulf Hansson <ulf.hansson@linaro.org>

parent f17b5f06

drivers/mmc/host/bcm2835.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1431,6 +1431,8 @@ static int bcm2835_probe(struct platform_device *pdev)

		err:
		dev_dbg(dev, "%s -> err %d\n", __func__, ret);
		if (host->dma_chan_rxtx)
		dma_release_channel(host->dma_chan_rxtx);
		mmc_free_host(mmc);

		return ret;

Admin message