Commit 8c8570fb authored by Dustin Kirkland's avatar Dustin Kirkland Committed by Al Viro
Browse files

[PATCH] Capture selinux subject/object context information. 



This patch extends existing audit records with subject/object context
information. Audit records associated with filesystem inodes, ipc, and
tasks now contain SELinux label information in the field "subj" if the
item is performing the action, or in "obj" if the item is the receiver
of an action.

These labels are collected via hooks in SELinux and appended to the
appropriate record in the audit code.

This additional information is required for Common Criteria Labeled
Security Protection Profile (LSPP).

[AV: fixed kmalloc flags use]
[folded leak fixes]
[folded cleanup from akpm (kfree(NULL)]
[folded audit_inode_context() leak fix]
[folded akpm's fix for audit_ipc_perm() definition in case of !CONFIG_AUDIT]

Signed-off-by: default avatarDustin Kirkland <dustin.kirkland@us.ibm.com>
Signed-off-by: default avatarDavid Woodhouse <dwmw2@infradead.org>
Signed-off-by: default avatarAndrew Morton <akpm@osdl.org>
Signed-off-by: default avatarAl Viro <viro@zeniv.linux.org.uk>
parent c8edc80c

include/linux/audit.h

+6 −2
Original line number Diff line number Diff line
@@ -285,13 +285,14 @@ extern void auditsc_get_stamp(struct audit_context *ctx, 
			      struct timespec *t, unsigned int *serial);

extern int  audit_set_loginuid(struct task_struct *task, uid_t loginuid);

extern uid_t audit_get_loginuid(struct audit_context *ctx);

extern int audit_ipc_perms(unsigned long qbytes, uid_t uid, gid_t gid, mode_t mode);

extern int audit_ipc_perms(unsigned long qbytes, uid_t uid, gid_t gid, mode_t mode, struct kern_ipc_perm *ipcp);

extern int audit_socketcall(int nargs, unsigned long *args);

extern int audit_sockaddr(int len, void *addr);

extern int audit_avc_path(struct dentry *dentry, struct vfsmount *mnt);

extern void audit_signal_info(int sig, struct task_struct *t);

extern int audit_filter_user(struct netlink_skb_parms *cb, int type);

extern int audit_filter_type(int type);

extern int audit_set_macxattr(const char *name);

#else

#define audit_alloc(t) ({ 0; })

#define audit_free(t) do { ; } while (0)
@@ -306,12 +307,13 @@ extern int audit_filter_type(int type); 
#define audit_receive_filter(t,p,u,s,d,l) ({ -EOPNOTSUPP; })

#define auditsc_get_stamp(c,t,s) do { BUG(); } while (0)

#define audit_get_loginuid(c) ({ -1; })

#define audit_ipc_perms(q,u,g,m) ({ 0; })

#define audit_ipc_perms(q,u,g,m,i) ({ 0; })

#define audit_socketcall(n,a) ({ 0; })

#define audit_sockaddr(len, addr) ({ 0; })

#define audit_avc_path(dentry, mnt) ({ 0; })

#define audit_signal_info(s,t) do { ; } while (0)

#define audit_filter_user(cb,t) ({ 1; })

#define audit_set_macxattr(n) do { ; } while (0)

#endif



#ifdef CONFIG_AUDIT
@@ -340,6 +342,7 @@ extern void audit_send_reply(int pid, int seq, int type, 
					     int done, int multi,

					     void *payload, int size);

extern void		    audit_log_lost(const char *message);

extern void		    audit_panic(const char *message);

extern struct semaphore audit_netlink_sem;

#else

#define audit_log(c,g,t,f,...) do { ; } while (0)
@@ -350,6 +353,7 @@ extern struct semaphore audit_netlink_sem; 
#define audit_log_hex(a,b,l) do { ; } while (0)

#define audit_log_untrustedstring(a,s) do { ; } while (0)

#define audit_log_d_path(b,p,d,v) do { ; } while (0)

#define audit_panic(m) do { ; } while (0)

#endif

#endif

#endif

include/linux/security.h

+27 −0
Original line number Diff line number Diff line
@@ -869,6 +869,11 @@ struct swap_info_struct; 
 *	@ipcp contains the kernel IPC permission structure

 *	@flag contains the desired (requested) permission set

 *	Return 0 if permission is granted.

 * @ipc_getsecurity:

 *      Copy the security label associated with the ipc object into

 *      @buffer.  @buffer may be NULL to request the size of the buffer 

 *      required.  @size indicates the size of @buffer in bytes. Return 

 *      number of bytes used/required on success.

 *

 * Security hooks for individual messages held in System V IPC message queues

 * @msg_msg_alloc_security:
@@ -1168,6 +1173,7 @@ struct security_operations { 
	int (*inode_getxattr) (struct dentry *dentry, char *name);

	int (*inode_listxattr) (struct dentry *dentry);

	int (*inode_removexattr) (struct dentry *dentry, char *name);

	char *(*inode_xattr_getsuffix) (void);

  	int (*inode_getsecurity)(struct inode *inode, const char *name, void *buffer, size_t size, int err);

  	int (*inode_setsecurity)(struct inode *inode, const char *name, const void *value, size_t size, int flags);

  	int (*inode_listsecurity)(struct inode *inode, char *buffer, size_t buffer_size);
@@ -1217,6 +1223,7 @@ struct security_operations { 
	void (*task_to_inode)(struct task_struct *p, struct inode *inode);



	int (*ipc_permission) (struct kern_ipc_perm * ipcp, short flag);

	int (*ipc_getsecurity)(struct kern_ipc_perm *ipcp, void *buffer, size_t size);



	int (*msg_msg_alloc_security) (struct msg_msg * msg);

	void (*msg_msg_free_security) (struct msg_msg * msg);
@@ -1674,6 +1681,11 @@ static inline int security_inode_removexattr (struct dentry *dentry, char *name) 
	return security_ops->inode_removexattr (dentry, name);

}



static inline const char *security_inode_xattr_getsuffix(void)

{

	return security_ops->inode_xattr_getsuffix();

}



static inline int security_inode_getsecurity(struct inode *inode, const char *name, void *buffer, size_t size, int err)

{

	if (unlikely (IS_PRIVATE (inode)))
@@ -1869,6 +1881,11 @@ static inline int security_ipc_permission (struct kern_ipc_perm *ipcp, 
	return security_ops->ipc_permission (ipcp, flag);

}



static inline int security_ipc_getsecurity(struct kern_ipc_perm *ipcp, void *buffer, size_t size)

{

	return security_ops->ipc_getsecurity(ipcp, buffer, size);

}



static inline int security_msg_msg_alloc (struct msg_msg * msg)

{

	return security_ops->msg_msg_alloc_security (msg);
@@ -2316,6 +2333,11 @@ static inline int security_inode_removexattr (struct dentry *dentry, char *name) 
	return cap_inode_removexattr(dentry, name);

}



static inline const char *security_inode_xattr_getsuffix (void)

{

	return NULL ;

}



static inline int security_inode_getsecurity(struct inode *inode, const char *name, void *buffer, size_t size, int err)

{

	return -EOPNOTSUPP;
@@ -2499,6 +2521,11 @@ static inline int security_ipc_permission (struct kern_ipc_perm *ipcp, 
	return 0;

}



static inline int security_ipc_getsecurity(struct kern_ipc_perm *ipcp, void *buffer, size_t size)

{

	return -EOPNOTSUPP;

}



static inline int security_msg_msg_alloc (struct msg_msg * msg)

{

	return 0;

ipc/msg.c

+3 −2
Original line number Diff line number Diff line
@@ -429,8 +429,6 @@ asmlinkage long sys_msgctl (int msqid, int cmd, struct msqid_ds __user *buf) 
			return -EFAULT;

		if (copy_msqid_from_user (&setbuf, buf, version))

			return -EFAULT;

		if ((err = audit_ipc_perms(setbuf.qbytes, setbuf.uid, setbuf.gid, setbuf.mode)))

			return err;

		break;

	case IPC_RMID:

		break;
@@ -461,6 +459,9 @@ asmlinkage long sys_msgctl (int msqid, int cmd, struct msqid_ds __user *buf) 
	switch (cmd) {

	case IPC_SET:

	{

		if ((err = audit_ipc_perms(setbuf.qbytes, setbuf.uid, setbuf.gid, setbuf.mode, ipcp)))

			goto out_unlock_up;



		err = -EPERM;

		if (setbuf.qbytes > msg_ctlmnb && !capable(CAP_SYS_RESOURCE))

			goto out_unlock_up;

ipc/sem.c

+2 −3
Original line number Diff line number Diff line
@@ -809,8 +809,6 @@ static int semctl_down(int semid, int semnum, int cmd, int version, union semun 
	if(cmd == IPC_SET) {

		if(copy_semid_from_user (&setbuf, arg.buf, version))

			return -EFAULT;

		if ((err = audit_ipc_perms(0, setbuf.uid, setbuf.gid, setbuf.mode)))

			return err;

	}

	sma = sem_lock(semid);

	if(sma==NULL)
@@ -821,7 +819,6 @@ static int semctl_down(int semid, int semnum, int cmd, int version, union semun 
		goto out_unlock;

	}	

	ipcp = &sma->sem_perm;

	

	if (current->euid != ipcp->cuid && 

	    current->euid != ipcp->uid && !capable(CAP_SYS_ADMIN)) {

	    	err=-EPERM;
@@ -838,6 +835,8 @@ static int semctl_down(int semid, int semnum, int cmd, int version, union semun 
		err = 0;

		break;

	case IPC_SET:

		if ((err = audit_ipc_perms(0, setbuf.uid, setbuf.gid, setbuf.mode, ipcp)))

			goto out_unlock;

		ipcp->uid = setbuf.uid;

		ipcp->gid = setbuf.gid;

		ipcp->mode = (ipcp->mode & ~S_IRWXUGO)

ipc/shm.c

+2 −2
Original line number Diff line number Diff line
@@ -620,13 +620,13 @@ asmlinkage long sys_shmctl (int shmid, int cmd, struct shmid_ds __user *buf) 
			err = -EFAULT;

			goto out;

		}

		if ((err = audit_ipc_perms(0, setbuf.uid, setbuf.gid, setbuf.mode)))

			return err;

		down(&shm_ids.sem);

		shp = shm_lock(shmid);

		err=-EINVAL;

		if(shp==NULL)

			goto out_up;

		if ((err = audit_ipc_perms(0, setbuf.uid, setbuf.gid, setbuf.mode, &(shp->shm_perm))))

			goto out_unlock_up;

		err = shm_checkid(shp,shmid);

		if(err)

			goto out_unlock_up;

CRA Git | Maintained and supported by SUSTech CRA and CCSE