Commit 8c7493aa authored Mar 31, 2017 by Eric Biggers Committed by Al Viro Apr 03, 2017

statx: reject unknown flags when using NULL path

The statx() system call currently accepts unknown flags when called with
a NULL path to operate on a file descriptor. Left unchanged, this could
make it hard to introduce new query flags in the future, since
applications may not be able to tell whether a given flag is supported.

Fix this by failing the system call with EINVAL if any flags other than
KSTAT_QUERY_FLAGS are specified in combination with a NULL path.

Arguably, we could still permit known lookup-related flags such as
AT_SYMLINK_NOFOLLOW. However, that would be inconsistent with how
sys_utimensat() behaves when passed a NULL path, which seems to be the
closest precedent. And given that the NULL path case is (I believe)
mainly intended to be used to implement a wrapper function like fstatx()
that doesn't have a path argument, I think rejecting lookup-related
flags too is probably the best choice.

Signed-off-by: Eric Biggers <ebiggers@google.com>
Signed-off-by: David Howells <dhowells@redhat.com>
Signed-off-by: Al Viro <viro@zeniv.linux.org.uk>

parent 75dd7e4b

fs/stat.c

+5 −1

Original line number	Diff line number	Diff line
		@@ -130,9 +130,13 @@ EXPORT_SYMBOL(vfs_getattr);
		int vfs_statx_fd(unsigned int fd, struct kstat *stat,
		u32 request_mask, unsigned int query_flags)
		{
		struct fd f = fdget_raw(fd);
		struct fd f;
		int error = -EBADF;

		if (query_flags & ~KSTAT_QUERY_FLAGS)
		return -EINVAL;

		f = fdget_raw(fd);
		if (f.file) {
		error = vfs_getattr(&f.file->f_path, stat,
		request_mask, query_flags);

Admin message