clk: ti: Fix memleak in ti_fapll_synth_setup (8c6239f6) · Commits · 戴 / test

If clk_register fails, we should goto free branch before function returns to prevent memleak. Fixes: ("clk: ti: Add support for FAPLL on dm816x") Reported-by:

Hulk Robot <hulkci@huawei.com> Signed-off-by:

Zhang Qilong <zhangqilong3@huawei.com> Link: https://lore.kernel.org/r/20201113131623.2098222-1-zhangqilong3@huawei.com Acked-by:

Tony Lindgren <tony@atomide.com> Signed-off-by:

Stephen Boyd <sboyd@kernel.org>

drivers/clk/ti/fapll.c

+9 −2

Original line number	Diff line number	Diff line
		@@ -498,6 +498,7 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd,
		{
		struct clk_init_data *init;
		struct fapll_synth *synth;
		struct clk *clk = ERR_PTR(-ENOMEM);

		init = kzalloc(sizeof(*init), GFP_KERNEL);
		if (!init)
		@@ -520,13 +521,19 @@ static struct clk * __init ti_fapll_synth_setup(struct fapll_data *fd,
		synth->hw.init = init;
		synth->clk_pll = pll_clk;

		return clk_register(NULL, &synth->hw);
		clk = clk_register(NULL, &synth->hw);
		if (IS_ERR(clk)) {
		pr_err("failed to register clock\n");
		goto free;
		}

		return clk;

		free:
		kfree(synth);
		kfree(init);

		return ERR_PTR(-ENOMEM);
		return clk;
		}

		static void __init ti_fapll_setup(struct device_node *node)

Admin message