Commit 8c3c818c authored Sep 09, 2020 by Steven Price

drm/panfrost: Ensure GPU quirks are always initialised

The GPU 'CONFIG' registers used to work around hardware issues are
cleared on reset so need to be programmed every time the GPU is reset.
However panfrost_device_reset() failed to do this.

To avoid this in future instead move the call to
panfrost_gpu_init_quirks() to panfrost_gpu_power_on() so that the
regsiters are always programmed just before the cores are powered.

Fixes: f3ba9122 ("drm/panfrost: Add initial panfrost driver")
Signed-off-by: Steven Price <steven.price@arm.com>
Reviewed-by: Alyssa Rosenzweig <alyssa.rosenzweig@collabora.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20200909122957.51667-1-steven.price@arm.com

parent ac5037af

drivers/gpu/drm/panfrost/panfrost_gpu.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -305,6 +305,8 @@ void panfrost_gpu_power_on(struct panfrost_device *pfdev)
		int ret;
		u32 val;

		panfrost_gpu_init_quirks(pfdev);

		/* Just turn on everything for now */
		gpu_write(pfdev, L2_PWRON_LO, pfdev->features.l2_present);
		ret = readl_relaxed_poll_timeout(pfdev->iomem + L2_READY_LO,
		@@ -357,7 +359,6 @@ int panfrost_gpu_init(struct panfrost_device *pfdev)
		return err;
		}

		panfrost_gpu_init_quirks(pfdev);
		panfrost_gpu_power_on(pfdev);

		return 0;