Unverified Commit 8c3590de authored Jan 03, 2019 by Yizhuo Committed by Mark Brown Jan 04, 2019

ASoC: Variable "val" in function rt274_i2c_probe() could be uninitialized



Inside function rt274_i2c_probe(), if regmap_read() function
returns -EINVAL, then local variable "val" leaves uninitialized
but used in if statement. This is potentially unsafe.

Signed-off-by: Yizhuo <yzhai003@ucr.edu>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 22c7d5e7

sound/soc/codecs/rt274.c

+4 −1

Original line number	Diff line number	Diff line
		@@ -1128,8 +1128,11 @@ static int rt274_i2c_probe(struct i2c_client *i2c,
		return ret;
		}

		regmap_read(rt274->regmap,
		ret = regmap_read(rt274->regmap,
		RT274_GET_PARAM(AC_NODE_ROOT, AC_PAR_VENDOR_ID), &val);
		if (ret)
		return ret;

		if (val != RT274_VENDOR_ID) {
		dev_err(&i2c->dev,
		"Device with ID register %#x is not rt274\n", val);

Admin message