sata_rcar: correct 'sata_rcar_sht' (8bfbeed5) · Commits · 戴 / test

Using ATA_BMDMA_SHT() to intialize 'sata_rcar_sht' was suboptimal as the R-Car descriptor table transfer counter is 28 bits wide (bit 1 to bit 28), so that the 'dma_boundary' field of 0xFFFF is just too small, as well as the 'sg_tablesize' field of 128. Use ATA_BASE_SHT() to initialize 'sata_rcar_sht' instead and give proper values to the 'dma_boundary' and 'sg_tablesize' fields explicitly. Signed-off-by:

Sergei Shtylyov <sergei.shtylyov@cogentembedded.com> Signed-off-by:

Tejun Heo <tj@kernel.org>

drivers/ata/sata_rcar.c

+10 −1

Original line number	Diff line number	Diff line
		@@ -121,6 +121,8 @@
		/* Descriptor table word 0 bit (when DTA32M = 1) */
		#define SATA_RCAR_DTEND BIT(0)

		#define SATA_RCAR_DMA_BOUNDARY 0x1FFFFFFEUL

		struct sata_rcar_priv {
		void __iomem *base;
		struct clk *clk;
		@@ -575,7 +577,14 @@ static u8 sata_rcar_bmdma_status(struct ata_port *ap)
		}

		static struct scsi_host_template sata_rcar_sht = {
		ATA_BMDMA_SHT(DRV_NAME),
		ATA_BASE_SHT(DRV_NAME),
		/*
		* This controller allows transfer chunks up to 512MB which cross 64KB
		* boundaries, therefore the DMA limits are more relaxed than standard
		* ATA SFF.
		*/
		.sg_tablesize = ATA_MAX_PRD,
		.dma_boundary = SATA_RCAR_DMA_BOUNDARY,
		};

		static struct ata_port_operations sata_rcar_port_ops = {

Admin message