Commit 8bf54381 authored by David S. Miller's avatar David S. Miller
Browse files

Merge branch 'dsa-use-per-port-upstream-port' 



Vivien Didelot says:

====================
net: dsa: use per-port upstream port

An upstream port is a local switch port used to reach a CPU port.

DSA still considers a unique CPU port in the whole switch fabric and
thus return a unique upstream port for a given switch. This is wrong in
a multiple CPU ports environment.

We are now switching to using the dedicated CPU port assigned to each
port in order to get rid of the deprecated unique tree CPU port.

This patchset makes the dsa_upstream_port() helper take a port argument
and goes one step closer complete support for multiple CPU ports.

Changes in v2:
  - reverse-christmas-tree-fy variables
====================

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parents 9382a506 07073c79

drivers/net/dsa/mv88e6xxx/chip.c

+39 −21
Original line number Original line Diff line number Diff line
@@ -1723,9 +1723,11 @@ static int mv88e6xxx_setup_message_port(struct mv88e6xxx_chip *chip, int port) 




static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port)

static int mv88e6xxx_setup_egress_floods(struct mv88e6xxx_chip *chip, int port)

{

{

	bool flood = port == dsa_upstream_port(chip->ds);

	struct dsa_switch *ds = chip->ds;

	bool flood;





	/* Upstream ports flood frames with unknown unicast or multicast DA */

	/* Upstream ports flood frames with unknown unicast or multicast DA */

	flood = dsa_is_cpu_port(ds, port) || dsa_is_dsa_port(ds, port);

	if (chip->info->ops->port_set_egress_floods)

	if (chip->info->ops->port_set_egress_floods)

		return chip->info->ops->port_set_egress_floods(chip, port,

		return chip->info->ops->port_set_egress_floods(chip, port,

							       flood, flood);

							       flood, flood);
@@ -1742,6 +1744,39 @@ static int mv88e6xxx_serdes_power(struct mv88e6xxx_chip *chip, int port, 
	return 0;

	return 0;

}

}





static int mv88e6xxx_setup_upstream_port(struct mv88e6xxx_chip *chip, int port)

{

	struct dsa_switch *ds = chip->ds;

	int upstream_port;

	int err;



	upstream_port = dsa_upstream_port(ds, port);

	if (chip->info->ops->port_set_upstream_port) {

		err = chip->info->ops->port_set_upstream_port(chip, port,

							      upstream_port);

		if (err)

			return err;

	}



	if (port == upstream_port) {

		if (chip->info->ops->set_cpu_port) {

			err = chip->info->ops->set_cpu_port(chip,

							    upstream_port);

			if (err)

				return err;

		}



		if (chip->info->ops->set_egress_port) {

			err = chip->info->ops->set_egress_port(chip,

							       upstream_port);

			if (err)

				return err;

		}

	}



	return 0;

}



static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)

static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port)

{

{

	struct dsa_switch *ds = chip->ds;

	struct dsa_switch *ds = chip->ds;
@@ -1812,13 +1847,9 @@ static int mv88e6xxx_setup_port(struct mv88e6xxx_chip *chip, int port) 
	if (err)

	if (err)

		return err;

		return err;





	reg = 0;

	err = mv88e6xxx_setup_upstream_port(chip, port);

	if (chip->info->ops->port_set_upstream_port) {

		err = chip->info->ops->port_set_upstream_port(

			chip, port, dsa_upstream_port(ds));

	if (err)

	if (err)

		return err;

		return err;

	}





	err = mv88e6xxx_port_set_8021q_mode(chip, port,

	err = mv88e6xxx_port_set_8021q_mode(chip, port,

				MV88E6XXX_PORT_CTL2_8021Q_MODE_DISABLED);

				MV88E6XXX_PORT_CTL2_8021Q_MODE_DISABLED);
@@ -1944,21 +1975,8 @@ static int mv88e6xxx_set_ageing_time(struct dsa_switch *ds, 
static int mv88e6xxx_g1_setup(struct mv88e6xxx_chip *chip)

static int mv88e6xxx_g1_setup(struct mv88e6xxx_chip *chip)

{

{

	struct dsa_switch *ds = chip->ds;

	struct dsa_switch *ds = chip->ds;

	u32 upstream_port = dsa_upstream_port(ds);

	int err;

	int err;





	if (chip->info->ops->set_cpu_port) {

		err = chip->info->ops->set_cpu_port(chip, upstream_port);

		if (err)

			return err;

	}



	if (chip->info->ops->set_egress_port) {

		err = chip->info->ops->set_egress_port(chip, upstream_port);

		if (err)

			return err;

	}



	/* Disable remote management, and set the switch's DSA device number. */

	/* Disable remote management, and set the switch's DSA device number. */

	err = mv88e6xxx_g1_write(chip, MV88E6XXX_G1_CTL2,

	err = mv88e6xxx_g1_write(chip, MV88E6XXX_G1_CTL2,

				 MV88E6XXX_G1_CTL2_MULTIPLE_CASCADE |

				 MV88E6XXX_G1_CTL2_MULTIPLE_CASCADE |

include/net/dsa.h

+6 −3
Original line number Original line Diff line number Diff line
@@ -307,10 +307,13 @@ static inline unsigned int dsa_towards_port(struct dsa_switch *ds, int device, 
}

}





/* Return the local port used to reach the dedicated CPU port */

/* Return the local port used to reach the dedicated CPU port */

static inline u8 dsa_upstream_port(struct dsa_switch *ds)

static inline unsigned int dsa_upstream_port(struct dsa_switch *ds, int port)

{

{

	struct dsa_switch_tree *dst = ds->dst;

	const struct dsa_port *dp = dsa_to_port(ds, port);

	struct dsa_port *cpu_dp = dst->cpu_dp;

	const struct dsa_port *cpu_dp = dp->cpu_dp;



	if (!cpu_dp)

		return port;





	return dsa_towards_port(ds, cpu_dp->ds->index, cpu_dp->index);

	return dsa_towards_port(ds, cpu_dp->ds->index, cpu_dp->index);

}

}

net/dsa/dsa2.c

+1 −1
Original line number Original line Diff line number Diff line
@@ -241,7 +241,7 @@ static int dsa_tree_setup_default_cpu(struct dsa_switch_tree *dst) 
		for (port = 0; port < ds->num_ports; port++) {

		for (port = 0; port < ds->num_ports; port++) {

			dp = &ds->ports[port];

			dp = &ds->ports[port];





			if (dsa_port_is_user(dp))

			if (dsa_port_is_user(dp) || dsa_port_is_dsa(dp))

				dp->cpu_dp = dst->cpu_dp;

				dp->cpu_dp = dst->cpu_dp;

		}

		}

	}

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE