Commit 8bdfc47f authored Sep 20, 2018 by Nathan Chancellor Committed by Greg Kroah-Hartman Sep 25, 2018

staging: wilc1000: Remove unnecessary pointer check

Clang warns that the address of a pointer will always evaluated as true
in a boolean context:

drivers/staging/wilc1000/linux_wlan.c:267:20: warning: address of
'vif->ndev->dev' will always evaluate to 'true'
[-Wpointer-bool-conversion]
        if (!(&vif->ndev->dev))
            ~  ~~~~~~~~~~~^~~
1 warning generated.

Since this statement always evaluates to false due to the logical not,
remove it.

Link: https://github.com/ClangBuiltLinux/linux/issues/121


Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Reviewed-by: Ajay Singh <ajay.kathat@microchip.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8de447ea

drivers/staging/wilc1000/linux_wlan.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -264,9 +264,6 @@ static int wilc_wlan_get_firmware(struct net_device *dev)

		netdev_info(dev, "loading firmware %s\n", firmware);

		if (!(&vif->ndev->dev))
		goto fail;

		if (request_firmware(&wilc_firmware, firmware, wilc->dev) != 0) {
		netdev_err(dev, "%s - firmware not available\n", firmware);
		ret = -1;

Admin message