Commit 8bbff39c authored by Andy Shevchenko's avatar Andy Shevchenko Committed by Bartosz Golaszewski
Browse files

gpiolib: Unify expectations about ->request() returned value 



Half of the code in the GPIO library is written in an expectation that
any non-zero value returned from the ->request() callback is an error code,
while some code checks only for negative values.

Unify expectations about ->request() returned value to be non-zero
for an error and 0 for the success.

Signed-off-by: default avatarAndy Shevchenko <andriy.shevchenko@linux.intel.com>
Signed-off-by: default avatarBartosz Golaszewski <bgolaszewski@baylibre.com>
parent 40941954

drivers/gpio/gpiolib-sysfs.c

+1 −1
Original line number Diff line number Diff line
@@ -476,7 +476,7 @@ static ssize_t export_store(struct class *class, 
	 */



	status = gpiod_request(desc, "sysfs");

	if (status < 0) {

	if (status) {

		if (status == -EPROBE_DEFER)

			status = -ENODEV;

		goto done;

drivers/gpio/gpiolib.c

+3 −3
Original line number Diff line number Diff line
@@ -1985,7 +1985,7 @@ static int gpiod_request_commit(struct gpio_desc *desc, const char *label) 
			ret = -EINVAL;

		spin_lock_irqsave(&gpio_lock, flags);



		if (ret < 0) {

		if (ret) {

			desc_set_label(desc, NULL);

			kfree_const(label);

			clear_bit(FLAG_REQUESTED, &desc->flags);
@@ -2051,7 +2051,7 @@ int gpiod_request(struct gpio_desc *desc, const char *label) 


	if (try_module_get(gdev->owner)) {

		ret = gpiod_request_commit(desc, label);

		if (ret < 0)

		if (ret)

			module_put(gdev->owner);

		else

			get_device(&gdev->dev);
@@ -3958,7 +3958,7 @@ struct gpio_desc *__must_check gpiod_get_index(struct device *dev, 
	 * the device name as label

	 */

	ret = gpiod_request(desc, con_id ? con_id : devname);

	if (ret < 0) {

	if (ret) {

		if (ret == -EBUSY && flags & GPIOD_FLAGS_BIT_NONEXCLUSIVE) {

			/*

			 * This happens when there are several consumers for

CRA Git | Maintained and supported by SUSTech CRA and CCSE