Commit 8b9b22ba authored Feb 07, 2017 by Wei Yongjun Committed by Martin K. Petersen Feb 09, 2017

scsi: qedi: Fix possible memory leak in qedi_iscsi_update_conn()



'conn_info' is malloced in qedi_iscsi_update_conn() and should be freed
before leaving from the error handling cases, otherwise it will cause
memory leak.

Fixes: ace7f46b ("scsi: qedi: Add QLogic FastLinQ offload iSCSI driver framework.")
Signed-off-by: Wei Yongjun <weiyongjun1@huawei.com>
Acked-by: Manish Rangankar <Manish.Rangankar@cavium.com>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>

parent 7942f7b5

drivers/scsi/qedi/qedi_iscsi.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -454,13 +454,9 @@ static int qedi_iscsi_update_conn(struct qedi_ctx *qedi,
		if (rval) {
		rval = -ENXIO;
		QEDI_ERR(&qedi->dbg_ctx, "Could not update connection\n");
		goto update_conn_err;
		}

		kfree(conn_info);
		rval = 0;

		update_conn_err:
		return rval;
		}

Admin message