Commit 8b9914cd authored by Ayush Sawal's avatar Ayush Sawal Committed by David S. Miller
Browse files

Crypto/chcr: Checking cra_refcnt before unregistering the algorithms 



This patch puts a check for algorithm unregister, to avoid removal of
driver if the algorithm is under use.

Signed-off-by: default avatarAyush Sawal <ayush.sawal@chelsio.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent fb90a1c8

drivers/crypto/chelsio/chcr_algo.c

+14 −4
Original line number Diff line number Diff line
@@ -4391,22 +4391,32 @@ static int chcr_unregister_alg(void) 
	for (i = 0; i < ARRAY_SIZE(driver_algs); i++) {

		switch (driver_algs[i].type & CRYPTO_ALG_TYPE_MASK) {

		case CRYPTO_ALG_TYPE_SKCIPHER:

			if (driver_algs[i].is_registered)

			if (driver_algs[i].is_registered && refcount_read(

			    &driver_algs[i].alg.skcipher.base.cra_refcnt)

			    == 1) {

				crypto_unregister_skcipher(

						&driver_algs[i].alg.skcipher);

				driver_algs[i].is_registered = 0;

			}

			break;

		case CRYPTO_ALG_TYPE_AEAD:

			if (driver_algs[i].is_registered)

			if (driver_algs[i].is_registered && refcount_read(

			    &driver_algs[i].alg.aead.base.cra_refcnt) == 1) {

				crypto_unregister_aead(

						&driver_algs[i].alg.aead);

				driver_algs[i].is_registered = 0;

			}

			break;

		case CRYPTO_ALG_TYPE_AHASH:

			if (driver_algs[i].is_registered)

			if (driver_algs[i].is_registered && refcount_read(

			    &driver_algs[i].alg.hash.halg.base.cra_refcnt)

			    == 1) {

				crypto_unregister_ahash(

						&driver_algs[i].alg.hash);

				driver_algs[i].is_registered = 0;

			}

			break;

		}

		driver_algs[i].is_registered = 0;

	}

	return 0;

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE