ACPI thermal: Check for thermal zone requirement (8b7ef6d8) · Commits · 戴 / test

ACPI spec says (11.5 Thermal Zone Interface Requirements): A thermal zone must contain at least one trip point (critical, near critical, active, or passive) Check this once at init time. Signed-off-by:

Thomas Renninger <trenn@suse.de> Tested-by:

<clarkt@cnsp.com> Signed-off-by:

Len Brown <len.brown@intel.com>

drivers/acpi/thermal.c

+17 −1

Original line number	Diff line number	Diff line
		@@ -575,7 +575,23 @@ static int acpi_thermal_trips_update(struct acpi_thermal *tz, int flag)

		static int acpi_thermal_get_trip_points(struct acpi_thermal *tz)
		{
		return acpi_thermal_trips_update(tz, ACPI_TRIPS_INIT);
		int i, valid, ret = acpi_thermal_trips_update(tz, ACPI_TRIPS_INIT);

		if (ret)
		return ret;

		valid = tz->trips.critical.flags.valid \|
		tz->trips.hot.flags.valid \|
		tz->trips.passive.flags.valid;

		for (i = 0; i < ACPI_THERMAL_MAX_ACTIVE; i++)
		valid \|= tz->trips.active[i].flags.valid;

		if (!valid) {
		printk(KERN_WARNING FW_BUG "No valid trip found\n");
		return -ENODEV;
		}
		return 0;
		}

		static void acpi_thermal_check(void *data)

Admin message