Commit 8b77484f authored Sep 09, 2017 by Trond Myklebust

NFS: Don't hold the group lock when calling nfs_release_request()



That can deadlock if this is the last reference since
nfs_page_group_destroy() calls nfs_page_group_sync_on_bit().
Note that even if the page was removed from the subpage list,
the req->wb_head could still be pointing to the old head.

Signed-off-by: Trond Myklebust <trond.myklebust@primarydata.com>

parent 5d2a9d9d

fs/nfs/write.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -532,9 +532,9 @@ try_again:
		} else if (WARN_ON_ONCE(subreq->wb_offset < head->wb_offset \|\|
		((subreq->wb_offset + subreq->wb_bytes) >
		(head->wb_offset + total_bytes)))) {
		nfs_page_group_unlock(head);
		nfs_unroll_locks(inode, head, subreq);
		nfs_unlock_and_release_request(subreq);
		nfs_page_group_unlock(head);
		nfs_unlock_and_release_request(head);
		return ERR_PTR(-EIO);
		}

Admin message