Commit 8b613bb8 authored by Tomas Winkler's avatar Tomas Winkler Committed by Greg Kroah-Hartman
Browse files

mei: bus: do not overflow the device name buffer 



1. use strncmp for comparsion strncpy was used for copying
which may omit the final %NUL terminator
2. id->name is statically defined so we can use sizeof

Acked-by: default avatarSamuel Ortiz <sameo@linux.intel.com>
Signed-off-by: default avatarTomas Winkler <tomas.winkler@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 5290801c

drivers/misc/mei/bus.c

+2 −2
Original line number Diff line number Diff line
@@ -47,7 +47,7 @@ static int mei_cl_device_match(struct device *dev, struct device_driver *drv) 
	id = driver->id_table;



	while (id->name[0]) {

		if (!strcmp(dev_name(dev), id->name))

		if (!strncmp(dev_name(dev), id->name, sizeof(id->name)))

			return 1;



		id++;
@@ -71,7 +71,7 @@ static int mei_cl_device_probe(struct device *dev) 


	dev_dbg(dev, "Device probe\n");



	strncpy(id.name, dev_name(dev), MEI_CL_NAME_SIZE);

	strncpy(id.name, dev_name(dev), sizeof(id.name));



	return driver->probe(device, &id);

}

CRA Git | Maintained and supported by SUSTech CRA and CCSE