Commit 8b5b9adb authored Apr 26, 2020 by Peter Chen Committed by Felipe Balbi May 25, 2020

usb: cdns3: ep0: delete the redundant status stage



Each setup stage will prepare status stage at cdns3_ep0_setup_phase,
it doesn't need to add extra status stage for test mode handling,
otherwise, the controller can't enter the test mode. Through the Lecroy
bus analyzer log, the controller will always wait status stage
even it is prepared by software later than the test mode is set
by software. If we comment out the status stage at cdns3_ep0_setup_phase,
the controller will not enter test mode even the test mode is set
beforehand.

Reviewed-by: Pawel Laszczak <pawell@cadence.com>
Signed-off-by: Peter Chen <peter.chen@nxp.com>
Signed-off-by: Felipe Balbi <balbi@kernel.org>

parent 65dc2e72

drivers/usb/cdns3/ep0.c

+0 −7

Original line number	Diff line number	Diff line
		@@ -332,13 +332,6 @@ static int cdns3_ep0_feature_handle_device(struct cdns3_device *priv_dev,
		case TEST_K:
		case TEST_SE0_NAK:
		case TEST_PACKET:
		cdns3_ep0_complete_setup(priv_dev, 0, 1);
		/**
		* Little delay to give the controller some time
		* for sending status stage.
		* This time should be less then 3ms.
		*/
		mdelay(1);
		cdns3_set_register_bit(&priv_dev->regs->usb_cmd,
		USB_CMD_STMODE \|
		USB_STS_TMODE_SEL(tmode - 1));

Admin message