Commit 8b58d12f authored Feb 15, 2019 by Vlad Buslov Committed by David S. Miller Feb 17, 2019

net: sched: cgroup: verify that filter is not NULL during walk



Check that filter is not NULL before passing it to tcf_walker->fn()
callback in cls_cgroup_walk(). This can happen when cls_cgroup_change()
failed to set first filter.

Fixes: ed76f5ed ("net: sched: protect filter_chain list with filter_chain_lock mutex")
Signed-off-by: Vlad Buslov <vladbu@mellanox.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d66022cd

net/sched/cls_cgroup.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -158,6 +158,8 @@ static void cls_cgroup_walk(struct tcf_proto tp, struct tcf_walker arg,
		if (arg->count < arg->skip)
		goto skip;

		if (!head)
		return;
		if (arg->fn(tp, head, arg) < 0) {
		arg->stop = 1;
		return;

Admin message