Commit 8b341349 authored Oct 15, 2020 by Alexandre Belloni

rtc: r9701: stop setting RWKCNT

tm_wday is never checked for validity and it is not read back in
r9701_get_datetime. Avoid setting it to stop tripping static checkers:

drivers/rtc/rtc-r9701.c:109 r9701_set_datetime()
error: undefined (user controlled) shift '1 << dt->tm_wday'

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>
Link: https://lore.kernel.org/r/20201015191135.471249-4-alexandre.belloni@bootlin.com

parent 2a8f3380

drivers/rtc/rtc-r9701.c

+0 −1

Original line number	Diff line number	Diff line
		@@ -100,7 +100,6 @@ static int r9701_set_datetime(struct device dev, struct rtc_time dt)
		ret = ret ? ret : write_reg(dev, RDAYCNT, bin2bcd(dt->tm_mday));
		ret = ret ? ret : write_reg(dev, RMONCNT, bin2bcd(dt->tm_mon + 1));
		ret = ret ? ret : write_reg(dev, RYRCNT, bin2bcd(dt->tm_year - 100));
		ret = ret ? ret : write_reg(dev, RWKCNT, 1 << dt->tm_wday);

		return ret;
		}