Commit 8b318f30 authored Mar 01, 2019 by Antoine Tenart Committed by David S. Miller Mar 01, 2019

net: mvpp2: fix validate for PPv2.1



The Phylink validate function is the Marvell PPv2 driver makes a check
on the GoP id. This is valid an has to be done when using PPv2.2 engines
but makes no sense when using PPv2.1. The check done when using an RGMII
interface makes sure the GoP id is not 0, but this breaks PPv2.1. Fixes
it.

Fixes: 0fb628f0 ("net: mvpp2: fix phylink handling of invalid PHY modes")
Signed-off-by: Antoine Tenart <antoine.tenart@bootlin.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent d78a1809

drivers/net/ethernet/marvell/mvpp2/mvpp2_main.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -4363,7 +4363,7 @@ static void mvpp2_phylink_validate(struct net_device *dev,
		case PHY_INTERFACE_MODE_RGMII_ID:
		case PHY_INTERFACE_MODE_RGMII_RXID:
		case PHY_INTERFACE_MODE_RGMII_TXID:
		if (port->gop_id == 0)
		if (port->priv->hw_version == MVPP22 && port->gop_id == 0)
		goto empty_set;
		break;
		default:

Admin message