Commit 8b27418f authored Oct 28, 2015 by Geert Uytterhoeven Committed by Mark Brown Nov 16, 2015

ASoC: rsnd: Add missing initialization of ADG req_rate



If the "clock-frequency" DT property is not found, req_rate is used
uninitialized, and the "audio_clkout" clock will be created with an
arbitrary clock rate.

This uninitialized kernel stack data may leak to userspace through
/sys/kernel/debug/clk/clk_summary, cfr. the value in the "rate" column:

       clock     enable_cnt  prepare_cnt        rate   accuracy   phase
    --------------------------------------------------------------------
     audio_clkout         0            0  4001836240          0 0

Signed-off-by: Geert Uytterhoeven <geert+renesas@glider.be>
Acked-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 9c66eedc

sound/soc/sh/rcar/adg.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -437,7 +437,7 @@ static void rsnd_adg_get_clkout(struct rsnd_priv *priv,
		struct device *dev = rsnd_priv_to_dev(priv);
		struct device_node *np = dev->of_node;
		u32 ckr, rbgx, rbga, rbgb;
		u32 rate, req_rate, div;
		u32 rate, req_rate = 0, div;
		uint32_t count = 0;
		unsigned long req_48kHz_rate, req_441kHz_rate;
		int i;

Admin message