Commit 8b208399 authored Apr 24, 2017 by Pan Bian Committed by Sebastian Reichel May 01, 2017

power: supply: isp1704: Fix unchecked return value of devm_kzalloc



Function devm_kzalloc() will return a NULL pointer. However, in function
isp1704_charger_probe(), the return value of devm_kzalloc() is directly
used without validation. This may result in a bad memory access bug.

Fixes: 34a10961 ("isp1704_charger: Add DT support")
Signed-off-by: Pan Bian <bianpan2016@163.com>
Reviewed-by: Pali Rohár <pali.rohar@gmail.com>
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.co.uk>

parent 756e142a

drivers/power/supply/isp1704_charger.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -418,6 +418,10 @@ static int isp1704_charger_probe(struct platform_device *pdev)

		pdata = devm_kzalloc(&pdev->dev,
		sizeof(struct isp1704_charger_data), GFP_KERNEL);
		if (!pdata) {
		ret = -ENOMEM;
		goto fail0;
		}
		pdata->enable_gpio = gpio;

		dev_info(&pdev->dev, "init gpio %d\n", pdata->enable_gpio);

Admin message