Commit 8af526e0 authored by Mark Bloch's avatar Mark Bloch Committed by Jason Gunthorpe
Browse files

RDMA/mlx5: Fix check for supported user flags when creating a QP 



When the flags verification was added two flags were missed from the
check:
 * MLX5_QP_FLAG_TIR_ALLOW_SELF_LB_UC
 * MLX5_QP_FLAG_TIR_ALLOW_SELF_LB_MC

This causes user applications that were using these flags to break.

Fixes: 2e43bb31 ("IB/mlx5: Verify that driver supports user flags")
Signed-off-by: default avatarMark Bloch <markb@mellanox.com>
Signed-off-by: default avatarLeon Romanovsky <leonro@mellanox.com>
Signed-off-by: default avatarJason Gunthorpe <jgg@mellanox.com>
parent 49a57857

drivers/infiniband/hw/mlx5/qp.c

+9 −7
Original line number Diff line number Diff line
@@ -1912,14 +1912,16 @@ static int create_qp_common(struct mlx5_ib_dev *dev, struct ib_pd *pd, 
		}



		if (!check_flags_mask(ucmd.flags,

				      MLX5_QP_FLAG_SIGNATURE |

				      MLX5_QP_FLAG_ALLOW_SCATTER_CQE |

				      MLX5_QP_FLAG_BFREG_INDEX |

				      MLX5_QP_FLAG_PACKET_BASED_CREDIT_MODE |

				      MLX5_QP_FLAG_SCATTER_CQE |

				      MLX5_QP_FLAG_SIGNATURE |

				      MLX5_QP_FLAG_TIR_ALLOW_SELF_LB_MC |

				      MLX5_QP_FLAG_TIR_ALLOW_SELF_LB_UC |

				      MLX5_QP_FLAG_TUNNEL_OFFLOADS |

					      MLX5_QP_FLAG_BFREG_INDEX |

					      MLX5_QP_FLAG_TYPE_DCT |

				      MLX5_QP_FLAG_TYPE_DCI |

					      MLX5_QP_FLAG_ALLOW_SCATTER_CQE |

					      MLX5_QP_FLAG_PACKET_BASED_CREDIT_MODE))

				      MLX5_QP_FLAG_TYPE_DCT))

			return -EINVAL;



		err = get_qp_user_index(to_mucontext(pd->uobject->context),

CRA Git | Maintained and supported by SUSTech CRA and CCSE