Commit 8aec4b87 authored May 09, 2019 by Nicholas Mc Guire Committed by Alexandre Belloni May 23, 2019

rtc: ds2404: use hw endiannes variable

Converting from hardware to host endiannes was done using reassignment
to the same variable which makes sparse unhappy as it can not verify
the endiannes handling properly. To allow sparse to verify endiannes
handling an explicit __le32 is introduced. Note that this patch does
not change the generated binary (x86_64 and ppc64 binary diff).

Signed-off-by: Nicholas Mc Guire <hofrat@osadl.org>
Signed-off-by: Alexandre Belloni <alexandre.belloni@bootlin.com>

parent a188339c

drivers/rtc/rtc-ds2404.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -182,9 +182,10 @@ static void ds2404_enable_osc(struct device *dev)
		static int ds2404_read_time(struct device dev, struct rtc_time dt)
		{
		unsigned long time = 0;
		__le32 hw_time = 0;

		ds2404_read_memory(dev, 0x203, 4, (u8 *)&time);
		time = le32_to_cpu(time);
		ds2404_read_memory(dev, 0x203, 4, (u8 *)&hw_time);
		time = le32_to_cpu(hw_time);

		rtc_time64_to_tm(time, dt);
		return 0;

Admin message