Commit 8adbe212 authored by Jiri Pirko's avatar Jiri Pirko Committed by David S. Miller
Browse files

mlxsw: spectrum: Disable lag port TX before removing it 



Make sure that lag port TX is disabled before mlxsw_sp_port_lag_leave()
is called and prevent from possible EMAD error.

Fixes: 0d65fc13 ("mlxsw: spectrum: Implement LAG port join/leave")
Signed-off-by: default avatarJiri Pirko <jiri@mellanox.com>
Signed-off-by: default avatarIdo Schimmel <idosch@mellanox.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 04d075b7

drivers/net/ethernet/mellanox/mlxsw/spectrum.c

+5 −2
Original line number Diff line number Diff line
@@ -5005,12 +5005,15 @@ static int mlxsw_sp_netdevice_port_upper_event(struct net_device *lower_dev, 
							   lower_dev,

							   upper_dev);

		} else if (netif_is_lag_master(upper_dev)) {

			if (info->linking)

			if (info->linking) {

				err = mlxsw_sp_port_lag_join(mlxsw_sp_port,

							     upper_dev);

			else

			} else {

				mlxsw_sp_port_lag_tx_en_set(mlxsw_sp_port,

							    false);

				mlxsw_sp_port_lag_leave(mlxsw_sp_port,

							upper_dev);

			}

		} else if (netif_is_ovs_master(upper_dev)) {

			if (info->linking)

				err = mlxsw_sp_port_ovs_join(mlxsw_sp_port);

CRA Git | Maintained and supported by SUSTech CRA and CCSE