Commit 8ad9ebb3 authored Nov 21, 2005 by Jens Axboe Committed by Linus Torvalds Nov 21, 2005

[PATCH] as-iosched: remove state assertion in as_add_request()

Kill the arq->state poison statement in as_add_request(), it can trigger
for perfectly valid code that just reuses a request after io completion
instead of freeing it and allocating a new one. We probably should
introduce a blk_init_request() to start from scratch, but for now just
kill it as we will be removing the as specific poisoning soon.

Signed-off-by: Jens Axboe <axboe@suse.de>
Signed-off-by: Linus Torvalds <torvalds@osdl.org>

parent f9e6bfa1

block/as-iosched.c

+0 −4

Original line number	Diff line number	Diff line
		@@ -1371,10 +1371,6 @@ static void as_add_request(request_queue_t q, struct request rq)
		struct as_rq *alias;
		int data_dir;

		if (arq->state != AS_RQ_PRESCHED) {
		printk("arq->state: %d\n", arq->state);
		WARN_ON(1);
		}
		arq->state = AS_RQ_NEW;

		if (rq_data_dir(arq->request) == READ

Admin message