Commit 8acbbfec authored by Pierre-Louis Bossart's avatar Pierre-Louis Bossart Committed by Vinod Koul
Browse files

soundwire: rename/clarify MIPI DisCo properties 



The existing definitions are ambiguous and possibly misleading.

For DP0, 'flow-control' is only relevant for the BRA protocol and
should not be confused with async modes explicitly not supported for
DP0, add prefix to follow MIPI DisCo definition

The use of 'device_interrupts' is also questionable. The MIPI
SoundWire spec defines Slave-, DP0- and DPN-level
implementation-defined interrupts. Using the 'device' prefix in the
last two cases is misleading, not only is the term 'device' overloaded
but these properties are only valid at the DP0 and DPn levels. Rename
to follow the MIPI definitions, no need to be creative here.

Signed-off-by: default avatarPierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
Signed-off-by: default avatarVinod Koul <vkoul@kernel.org>
parent f6686a7d

drivers/soundwire/bus.c

+1 −1
Original line number Diff line number Diff line
@@ -648,7 +648,7 @@ static int sdw_initialize_slave(struct sdw_slave *slave) 
		return 0;



	/* Enable DP0 interrupts */

	val = prop->dp0_prop->device_interrupts;

	val = prop->dp0_prop->imp_def_interrupts;

	val |= SDW_DP0_INT_PORT_READY | SDW_DP0_INT_BRA_FAILURE;



	ret = sdw_update(slave, SDW_DP0_INTMASK, val, val);

drivers/soundwire/mipi_disco.c

+3 −3
Original line number Diff line number Diff line
@@ -150,13 +150,13 @@ static int sdw_slave_read_dp0(struct sdw_slave *slave, 
				dp0->words, dp0->num_words);

	}



	dp0->flow_controlled = fwnode_property_read_bool(port,

	dp0->BRA_flow_controlled = fwnode_property_read_bool(port,

				"mipi-sdw-bra-flow-controlled");



	dp0->simple_ch_prep_sm = fwnode_property_read_bool(port,

				"mipi-sdw-simplified-channel-prepare-sm");



	dp0->device_interrupts = fwnode_property_read_bool(port,

	dp0->imp_def_interrupts = fwnode_property_read_bool(port,

				"mipi-sdw-imp-def-dp0-interrupts-supported");



	return 0;
@@ -225,7 +225,7 @@ static int sdw_slave_read_dpn(struct sdw_slave *slave, 


		fwnode_property_read_u32(node,

				"mipi-sdw-imp-def-dpn-interrupts-supported",

				&dpn[i].device_interrupts);

				&dpn[i].imp_def_interrupts);



		fwnode_property_read_u32(node, "mipi-sdw-min-channel-number",

					 &dpn[i].min_ch);

drivers/soundwire/stream.c

+3 −3
Original line number Diff line number Diff line
@@ -439,7 +439,7 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus, 


	prep_ch.bank = bus->params.next_bank;



	if (dpn_prop->device_interrupts || !dpn_prop->simple_ch_prep_sm)

	if (dpn_prop->imp_def_interrupts || !dpn_prop->simple_ch_prep_sm)

		intr = true;



	/*
@@ -449,7 +449,7 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus, 
	 */

	if (prep && intr) {

		ret = sdw_configure_dpn_intr(s_rt->slave, p_rt->num, prep,

					     dpn_prop->device_interrupts);

					     dpn_prop->imp_def_interrupts);

		if (ret < 0)

			return ret;

	}
@@ -493,7 +493,7 @@ static int sdw_prep_deprep_slave_ports(struct sdw_bus *bus, 
	/* Disable interrupt after Port de-prepare */

	if (!prep && intr)

		ret = sdw_configure_dpn_intr(s_rt->slave, p_rt->num, prep,

					     dpn_prop->device_interrupts);

					     dpn_prop->imp_def_interrupts);



	return ret;

}

include/linux/soundwire/sdw.h

+7 −6
Original line number Diff line number Diff line
@@ -206,10 +206,11 @@ enum sdw_clk_stop_mode { 
 * (inclusive)

 * @num_words: number of wordlengths supported

 * @words: wordlengths supported

 * @flow_controlled: Slave implementation results in an OK_NotReady

 * @BRA_flow_controlled: Slave implementation results in an OK_NotReady

 * response

 * @simple_ch_prep_sm: If channel prepare sequence is required

 * @device_interrupts: If implementation-defined interrupts are supported

 * @imp_def_interrupts: If set, each bit corresponds to support for

 * implementation-defined interrupts

 *

 * The wordlengths are specified by Spec as max, min AND number of

 * discrete values, implementation can define based on the wordlengths they
@@ -220,9 +221,9 @@ struct sdw_dp0_prop { 
	u32 min_word;

	u32 num_words;

	u32 *words;

	bool flow_controlled;

	bool BRA_flow_controlled;

	bool simple_ch_prep_sm;

	bool device_interrupts;

	bool imp_def_interrupts;

};



/**
@@ -272,7 +273,7 @@ struct sdw_dpn_audio_mode { 
 * @simple_ch_prep_sm: If the port supports simplified channel prepare state

 * machine

 * @ch_prep_timeout: Port-specific timeout value, in milliseconds

 * @device_interrupts: If set, each bit corresponds to support for

 * @imp_def_interrupts: If set, each bit corresponds to support for

 * implementation-defined interrupts

 * @max_ch: Maximum channels supported

 * @min_ch: Minimum channels supported
@@ -297,7 +298,7 @@ struct sdw_dpn_prop { 
	u32 max_grouping;

	bool simple_ch_prep_sm;

	u32 ch_prep_timeout;

	u32 device_interrupts;

	u32 imp_def_interrupts;

	u32 max_ch;

	u32 min_ch;

	u32 num_ch;

CRA Git | Maintained and supported by SUSTech CRA and CCSE