Commit 8aabf0ed authored Jun 06, 2019 by Eric Farman Committed by Cornelia Huck Jun 17, 2019

vfio-ccw: Adjust the first IDAW outside of the nested loops



Now that pfn_array_table[] is always an array of 1, it seems silly to
check for the very first entry in an array in the middle of two nested
loops, since we know it'll only ever happen once.

Let's move this outside the loops to simplify things, even though
the "k" variable is still necessary.

Signed-off-by: Eric Farman <farman@linux.ibm.com>
Reviewed-by: Cornelia Huck <cohuck@redhat.com>
Message-Id: <20190606202831.44135-7-farman@linux.ibm.com>
Signed-off-by: Cornelia Huck <cohuck@redhat.com>

parent cc06ee98

drivers/s390/cio/vfio_ccw_cp.c

+3 −2

Original line number	Diff line number	Diff line
		@@ -201,11 +201,12 @@ static inline void pfn_array_table_idal_create_words(
		pa = pat->pat_pa + i;
		for (j = 0; j < pa->pa_nr; j++) {
		idaws[k] = pa->pa_pfn[j] << PAGE_SHIFT;
		if (k == 0)
		idaws[k] += pa->pa_iova & (PAGE_SIZE - 1);
		k++;
		}
		}

		/* Adjust the first IDAW, since it may not start on a page boundary */
		idaws[0] += pat->pat_pa->pa_iova & (PAGE_SIZE - 1);
		}

Admin message