Commit 8a97d428 authored by Krzysztof Kozlowski's avatar Krzysztof Kozlowski Committed by Lee Jones
Browse files

mfd: sec-core: Disable buck voltage reset on watchdog falling edge 



The WRSTBI bit (disabled by default but enabled by bootloader), when
set, is responsible for resetting voltages to default values of
certain bucks on falling edge of Warm Reset Input pin from AP.

However on some boards (with S2MPS13) the pin is pulled down so any
suspend will effectively trigger the reset of bucks supplying the power
to the little and big cores. In the same time when resuming, these bucks
must provide voltage greater or equal to voltage before suspend to match
the frequency chosen by cpufreq. If voltage (default value of voltage
after reset) is lower than one set by cpufreq before suspend, then
system will hang during resuming.

Signed-off-by: default avatarKrzysztof Kozlowski <k.kozlowski@samsung.com>
Reported-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Tested-by: default avatarBartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
Signed-off-by: default avatarLee Jones <lee.jones@linaro.org>
parent c2c9f1fe

drivers/mfd/sec-core.c

+26 −0
Original line number Diff line number Diff line
@@ -262,6 +262,29 @@ static void sec_pmic_dump_rev(struct sec_pmic_dev *sec_pmic) 
		dev_dbg(sec_pmic->dev, "Revision: 0x%x\n", val);

}



static void sec_pmic_configure(struct sec_pmic_dev *sec_pmic)

{

	int err;



	if (sec_pmic->device_type != S2MPS13X)

		return;



	if (sec_pmic->pdata->disable_wrstbi) {

		/*

		 * If WRSTBI pin is pulled down this feature must be disabled

		 * because each Suspend to RAM will trigger buck voltage reset

		 * to default values.

		 */

		err = regmap_update_bits(sec_pmic->regmap_pmic,

					 S2MPS13_REG_WRSTBI,

					 S2MPS13_REG_WRSTBI_MASK, 0x0);

		if (err)

			dev_warn(sec_pmic->dev,

				 "Cannot initialize WRSTBI config: %d\n",

				 err);

	}

}



#ifdef CONFIG_OF

/*

 * Only the common platform data elements for s5m8767 are parsed here from the
@@ -289,6 +312,8 @@ static struct sec_platform_data *sec_pmic_i2c_parse_dt_pdata( 


	pd->manual_poweroff = of_property_read_bool(dev->of_node,

						"samsung,s2mps11-acokb-ground");

	pd->disable_wrstbi = of_property_read_bool(dev->of_node,

						"samsung,s2mps11-wrstbi-ground");

	return pd;

}

#else
@@ -434,6 +459,7 @@ static int sec_pmic_probe(struct i2c_client *i2c, 
		goto err_mfd;



	device_init_wakeup(sec_pmic->dev, sec_pmic->wakeup);

	sec_pmic_configure(sec_pmic);

	sec_pmic_dump_rev(sec_pmic);



	return ret;

include/linux/mfd/samsung/core.h

+2 −0
Original line number Diff line number Diff line
@@ -134,6 +134,8 @@ struct sec_platform_data { 
	int				buck4_init;

	/* Whether or not manually set PWRHOLD to low during shutdown. */

	bool				manual_poweroff;

	/* Disable the WRSTBI (buck voltage warm reset) when probing? */

	bool				disable_wrstbi;

};



/**

include/linux/mfd/samsung/s2mps13.h

+1 −0
Original line number Diff line number Diff line
@@ -184,5 +184,6 @@ enum s2mps13_regulators { 
 * Let's assume that default value will be set.

 */

#define S2MPS13_BUCK_RAMP_DELAY		12500

#define S2MPS13_REG_WRSTBI_MASK		BIT(5)



#endif /*  __LINUX_MFD_S2MPS13_H */

CRA Git | Maintained and supported by SUSTech CRA and CCSE