Commit 8a962c4a authored Nov 16, 2018 by Nathan Chancellor Committed by David S. Miller Nov 17, 2018

geneve: Initialize addr6 with memset



Clang warns:

drivers/net/geneve.c:428:29: error: suggest braces around initialization
of subobject [-Werror,-Wmissing-braces]
                struct in6_addr addr6 = { 0 };
                                          ^
                                          {}

Rather than trying to appease the various compilers that support the
kernel, use memset, which is unambiguous.

Fixes: a0796644 ("geneve: ICMP error lookup handler")
Suggested-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Nathan Chancellor <natechancellor@gmail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 52c951f1

drivers/net/geneve.c

+3 −1

Original line number	Original line	Diff line number	Diff line
	@@ -425,7 +425,9 @@ static int geneve_udp_encap_err_lookup(struct sock sk, struct sk_buff skb)
	#if IS_ENABLED(CONFIG_IPV6)		#if IS_ENABLED(CONFIG_IPV6)
	if (geneve_get_sk_family(gs) == AF_INET6) {		if (geneve_get_sk_family(gs) == AF_INET6) {
	struct ipv6hdr *ip6h = ipv6_hdr(skb);		struct ipv6hdr *ip6h = ipv6_hdr(skb);
	struct in6_addr addr6 = { 0 };		struct in6_addr addr6;

			memset(&addr6, 0, sizeof(struct in6_addr));

	if (!gs->collect_md) {		if (!gs->collect_md) {
	vni = geneve_hdr(skb)->vni;		vni = geneve_hdr(skb)->vni;

Admin message