Unverified Commit 8a90efd1 authored Jun 28, 2019 by Kuninori Morimoto Committed by Mark Brown Jun 28, 2019

ASoC: vc4: vc4_htmi: consider CPU-Platform possibility



commit 6c6de1c9 ("ASoC: vc4: vc4_hdmi: don't select unnecessary
Platform")

Current ALSA SoC avoid to add duplicate component to rtd,
and this driver was selecting CPU component as Platform component.
Thus, above patch removed Platform settings from this driver,
because it assumed these are same component.

But, some CPU driver is using generic DMAEngine, in such case, both
CPU component and Platform component will have same of_node/name.
In other words, there are some components which are different but
have same of_node/name.

In such case, Card driver definitely need to select Platform even
though it is same as CPU.
It is depends on CPU driver, but is difficult to know it from Card driver.
This patch reverts above patch.

Fixes: commit 6c6de1c9 ("ASoC: vc4: vc4_hdmi: don't select unnecessary Platform")
Signed-off-by: Kuninori Morimoto <kuninori.morimoto.gx@renesas.com>
Signed-off-by: Mark Brown <broonie@kernel.org>

parent 1ad741d0

drivers/gpu/drm/vc4/vc4_hdmi.c

+4 −0

Original line number	Diff line number	Diff line
		@@ -60,6 +60,7 @@ struct vc4_hdmi_audio {
		struct snd_soc_dai_link link;
		struct snd_soc_dai_link_component cpu;
		struct snd_soc_dai_link_component codec;
		struct snd_soc_dai_link_component platform;
		int samplerate;
		int channels;
		struct snd_dmaengine_dai_dma_data dma_data;
		@@ -1089,15 +1090,18 @@ static int vc4_hdmi_audio_init(struct vc4_hdmi *hdmi)

		dai_link->cpus = &hdmi->audio.cpu;
		dai_link->codecs = &hdmi->audio.codec;
		dai_link->platforms = &hdmi->audio.platform;

		dai_link->num_cpus = 1;
		dai_link->num_codecs = 1;
		dai_link->num_platforms = 1;

		dai_link->name = "MAI";
		dai_link->stream_name = "MAI PCM";
		dai_link->codecs->dai_name = vc4_hdmi_audio_codec_dai_drv.name;
		dai_link->cpus->dai_name = dev_name(dev);
		dai_link->codecs->name = dev_name(dev);
		dai_link->platforms->name = dev_name(dev);

		card->dai_link = dai_link;
		card->num_links = 1;

Admin message