Commit 8a8b836b authored by David S. Miller's avatar David S. Miller
Browse files

[SPARC]: Make bitops use same spinlocks as atomics. 



Recent workqueue changes basically make this a formal requirement.

Also, move atomic32.o from lib-y to obj-y since it exports symbols
to modules.

Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 216da721

arch/sparc/kernel/sparc_ksyms.c

+0 −8
Original line number Diff line number Diff line
@@ -83,9 +83,6 @@ extern int __divdi3(int, int); 
/* Private functions with odd calling conventions. */

extern void ___atomic24_add(void);

extern void ___atomic24_sub(void);

extern void ___set_bit(void);

extern void ___clear_bit(void);

extern void ___change_bit(void);

extern void ___rw_read_enter(void);

extern void ___rw_read_try(void);

extern void ___rw_read_exit(void);
@@ -125,11 +122,6 @@ EXPORT_SYMBOL(pfn_base); 
EXPORT_SYMBOL(___atomic24_add);

EXPORT_SYMBOL(___atomic24_sub);



/* Bit operations. */

EXPORT_SYMBOL(___set_bit);

EXPORT_SYMBOL(___clear_bit);

EXPORT_SYMBOL(___change_bit);



/* Per-CPU information table */

EXPORT_PER_CPU_SYMBOL(__cpu_data);

arch/sparc/kernel/time.c

+1 −4
Original line number Diff line number Diff line
@@ -78,7 +78,6 @@ unsigned long profile_pc(struct pt_regs *regs) 
	extern char __copy_user_begin[], __copy_user_end[];

	extern char __atomic_begin[], __atomic_end[];

	extern char __bzero_begin[], __bzero_end[];

	extern char __bitops_begin[], __bitops_end[];



	unsigned long pc = regs->pc;
@@ -88,9 +87,7 @@ unsigned long profile_pc(struct pt_regs *regs) 
	    (pc >= (unsigned long) __atomic_begin &&

	     pc < (unsigned long) __atomic_end) ||

	    (pc >= (unsigned long) __bzero_begin &&

	     pc < (unsigned long) __bzero_end) ||

	    (pc >= (unsigned long) __bitops_begin &&

	     pc < (unsigned long) __bitops_end))

	     pc < (unsigned long) __bzero_end))

		pc = regs->u_regs[UREG_RETPC];

	return pc;

}

arch/sparc/lib/Makefile

+2 −2
Original line number Diff line number Diff line
@@ -7,7 +7,7 @@ EXTRA_AFLAGS := -ansi -DST_DIV0=0x02 
lib-y := mul.o rem.o sdiv.o udiv.o umul.o urem.o ashrdi3.o memcpy.o memset.o \

         strlen.o checksum.o blockops.o memscan.o memcmp.o strncmp.o \

	 strncpy_from_user.o divdi3.o udivdi3.o strlen_user.o \

	 copy_user.o locks.o atomic.o atomic32.o bitops.o \

	 copy_user.o locks.o atomic.o \

	 lshrdi3.o ashldi3.o rwsem.o muldi3.o bitext.o



obj-y += iomap.o
 
obj-y += iomap.o atomic32.o

arch/sparc/lib/atomic32.c

+39 −0
Original line number Diff line number Diff line
@@ -76,3 +76,42 @@ void atomic_set(atomic_t *v, int i) 
	spin_unlock_irqrestore(ATOMIC_HASH(v), flags);

}

EXPORT_SYMBOL(atomic_set);



unsigned long ___set_bit(unsigned long *addr, unsigned long mask)

{

	unsigned long old, flags;



	spin_lock_irqsave(ATOMIC_HASH(addr), flags);

	old = *addr;

	*addr = old | mask;

	spin_unlock_irqrestore(ATOMIC_HASH(addr), flags);



	return old & mask;

}

EXPORT_SYMBOL(___set_bit);



unsigned long ___clear_bit(unsigned long *addr, unsigned long mask)

{

	unsigned long old, flags;



	spin_lock_irqsave(ATOMIC_HASH(addr), flags);

	old = *addr;

	*addr = old & ~mask;

	spin_unlock_irqrestore(ATOMIC_HASH(addr), flags);



	return old & mask;

}

EXPORT_SYMBOL(___clear_bit);



unsigned long ___change_bit(unsigned long *addr, unsigned long mask)

{

	unsigned long old, flags;



	spin_lock_irqsave(ATOMIC_HASH(addr), flags);

	old = *addr;

	*addr = old ^ mask;

	spin_unlock_irqrestore(ATOMIC_HASH(addr), flags);



	return old & mask;

}

EXPORT_SYMBOL(___change_bit);

arch/sparc/lib/bitops.S

deleted100644 → 0
+0 −109
Original line number Diff line number Diff line 
/* bitops.S: Low level assembler bit operations.

 *

 * Copyright (C) 1996 David S. Miller (davem@caip.rutgers.edu)

 */



#include <asm/ptrace.h>

#include <asm/psr.h>



	.text

	.align	4



	.globl  __bitops_begin

__bitops_begin:



	/* Take bits in %g2 and set them in word at %g1,

	 * return whether bits were set in original value

	 * in %g2.  %g4 holds value to restore into %o7

	 * in delay slot of jmpl return, %g3 + %g5 + %g7 can be

	 * used as temporaries and thus is considered clobbered

	 * by all callers.

	 */

	.globl	___set_bit

___set_bit:

	rd	%psr, %g3

	nop; nop; nop;

	or	%g3, PSR_PIL, %g5

	wr	%g5, 0x0, %psr

	nop; nop; nop

#ifdef CONFIG_SMP

	set	bitops_spinlock, %g5

2:	ldstub	[%g5], %g7		! Spin on the byte lock for SMP.

	orcc	%g7, 0x0, %g0		! Did we get it?

	bne	2b			! Nope...

#endif

	 ld	[%g1], %g7

	or	%g7, %g2, %g5

	and	%g7, %g2, %g2

#ifdef CONFIG_SMP

	st	%g5, [%g1]

	set	bitops_spinlock, %g5

	stb	%g0, [%g5]

#else

	st	%g5, [%g1]

#endif

	wr	%g3, 0x0, %psr

	nop; nop; nop

	jmpl	%o7, %g0

	 mov	%g4, %o7



	/* Same as above, but clears the bits from %g2 instead. */

	.globl	___clear_bit

___clear_bit:

	rd	%psr, %g3

	nop; nop; nop

	or	%g3, PSR_PIL, %g5

	wr	%g5, 0x0, %psr

	nop; nop; nop

#ifdef CONFIG_SMP

	set	bitops_spinlock, %g5

2:	ldstub	[%g5], %g7		! Spin on the byte lock for SMP.

	orcc	%g7, 0x0, %g0		! Did we get it?

	bne	2b			! Nope...

#endif

	 ld	[%g1], %g7

	andn	%g7, %g2, %g5

	and	%g7, %g2, %g2

#ifdef CONFIG_SMP

	st	%g5, [%g1]

	set	bitops_spinlock, %g5

	stb	%g0, [%g5]

#else

	st	%g5, [%g1]

#endif

	wr	%g3, 0x0, %psr

	nop; nop; nop

	jmpl	%o7, %g0

	 mov	%g4, %o7



	/* Same thing again, but this time toggles the bits from %g2. */

	.globl	___change_bit

___change_bit:

	rd	%psr, %g3

	nop; nop; nop

	or	%g3, PSR_PIL, %g5

	wr	%g5, 0x0, %psr

	nop; nop; nop

#ifdef CONFIG_SMP

	set	bitops_spinlock, %g5

2:	ldstub	[%g5], %g7		! Spin on the byte lock for SMP.

	orcc	%g7, 0x0, %g0		! Did we get it?

	bne	2b			! Nope...

#endif

	 ld	[%g1], %g7

	xor	%g7, %g2, %g5

	and	%g7, %g2, %g2

#ifdef CONFIG_SMP

	st	%g5, [%g1]

	set	bitops_spinlock, %g5

	stb	%g0, [%g5]

#else

	st	%g5, [%g1]

#endif

	wr	%g3, 0x0, %psr

	nop; nop; nop

	jmpl	%o7, %g0

	 mov	%g4, %o7



	.globl  __bitops_end

__bitops_end:

CRA Git | Maintained and supported by SUSTech CRA and CCSE