Commit 8a84bacb authored by Imre Deak's avatar Imre Deak
Browse files

drm/i915: Align power domain names with port names 



There is a difference in BSpec's and the driver's designation of DDI
ports. BSpec uses the following names:
- before GEN11:
  BSpec/driver:
  	port A/B/C/D etc
- GEN11:
  BSpec/driver:
	port A-F
- GEN12:
  BSpec:
  	port A/B/C for combo PHY ports
	port TC1-6 for Type C PHY ports
  driver:
	port A-I.
  The driver's port D name matches BSpec's TC1 port name.

So far power domains were named according to the BSpec designation, to
make it easier to match the code against the specification. That however
can be confusing when a power domain needs to be matched to a port on
GEN12+. To resolve that use the driver's port A-I designation for power
domain names too and rename the corresponding power wells so that they
reflect the mapping from the driver's to BSpec's port name.

Cc: Lucas De Marchi <lucas.demarchi@intel.com>
Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
Signed-off-by: default avatarImre Deak <imre.deak@intel.com>
Reviewed-by: default avatarStanislav Lisovskiy <stanislav.lisovskiy@intel.com>
Link: https://patchwork.freedesktop.org/patch/msgid/20190823100711.27833-1-imre.deak@intel.com
parent 325b916a

drivers/gpu/drm/i915/display/intel_display.c

+5 −5
Original line number Diff line number Diff line
@@ -6737,16 +6737,16 @@ intel_aux_power_domain(struct intel_digital_port *dig_port) 
	    dig_port->tc_mode == TC_PORT_TBT_ALT) {

		switch (dig_port->aux_ch) {

		case AUX_CH_C:

			return POWER_DOMAIN_AUX_TBT1;

			return POWER_DOMAIN_AUX_C_TBT;

		case AUX_CH_D:

			return POWER_DOMAIN_AUX_TBT2;

			return POWER_DOMAIN_AUX_D_TBT;

		case AUX_CH_E:

			return POWER_DOMAIN_AUX_TBT3;

			return POWER_DOMAIN_AUX_E_TBT;

		case AUX_CH_F:

			return POWER_DOMAIN_AUX_TBT4;

			return POWER_DOMAIN_AUX_F_TBT;

		default:

			MISSING_CASE(dig_port->aux_ch);

			return POWER_DOMAIN_AUX_TBT1;

			return POWER_DOMAIN_AUX_C_TBT;

		}

	}

drivers/gpu/drm/i915/display/intel_display_power.c

+178 −183

File changed.

Preview size limit exceeded, changes collapsed.

drivers/gpu/drm/i915/display/intel_display_power.h

+14 −26
Original line number Diff line number Diff line
@@ -36,29 +36,20 @@ enum intel_display_power_domain { 
	POWER_DOMAIN_PORT_DDI_B_LANES,

	POWER_DOMAIN_PORT_DDI_C_LANES,

	POWER_DOMAIN_PORT_DDI_D_LANES,

	POWER_DOMAIN_PORT_DDI_TC1_LANES = POWER_DOMAIN_PORT_DDI_D_LANES,

	POWER_DOMAIN_PORT_DDI_E_LANES,

	POWER_DOMAIN_PORT_DDI_TC2_LANES = POWER_DOMAIN_PORT_DDI_E_LANES,

	POWER_DOMAIN_PORT_DDI_F_LANES,

	POWER_DOMAIN_PORT_DDI_TC3_LANES = POWER_DOMAIN_PORT_DDI_F_LANES,

	POWER_DOMAIN_PORT_DDI_TC4_LANES,

	POWER_DOMAIN_PORT_DDI_TC5_LANES,

	POWER_DOMAIN_PORT_DDI_TC6_LANES,

	POWER_DOMAIN_PORT_DDI_G_LANES,

	POWER_DOMAIN_PORT_DDI_H_LANES,

	POWER_DOMAIN_PORT_DDI_I_LANES,

	POWER_DOMAIN_PORT_DDI_A_IO,

	POWER_DOMAIN_PORT_DDI_B_IO,

	POWER_DOMAIN_PORT_DDI_C_IO,

	POWER_DOMAIN_PORT_DDI_D_IO,

	POWER_DOMAIN_PORT_DDI_TC1_IO = POWER_DOMAIN_PORT_DDI_D_IO,

	POWER_DOMAIN_PORT_DDI_E_IO,

	POWER_DOMAIN_PORT_DDI_TC2_IO = POWER_DOMAIN_PORT_DDI_E_IO,

	POWER_DOMAIN_PORT_DDI_F_IO,

	POWER_DOMAIN_PORT_DDI_TC3_IO = POWER_DOMAIN_PORT_DDI_F_IO,

	POWER_DOMAIN_PORT_DDI_G_IO,

	POWER_DOMAIN_PORT_DDI_TC4_IO = POWER_DOMAIN_PORT_DDI_G_IO,

	POWER_DOMAIN_PORT_DDI_H_IO,

	POWER_DOMAIN_PORT_DDI_TC5_IO = POWER_DOMAIN_PORT_DDI_H_IO,

	POWER_DOMAIN_PORT_DDI_I_IO,

	POWER_DOMAIN_PORT_DDI_TC6_IO = POWER_DOMAIN_PORT_DDI_I_IO,

	POWER_DOMAIN_PORT_DSI,

	POWER_DOMAIN_PORT_CRT,

	POWER_DOMAIN_PORT_OTHER,
@@ -68,21 +59,19 @@ enum intel_display_power_domain { 
	POWER_DOMAIN_AUX_B,

	POWER_DOMAIN_AUX_C,

	POWER_DOMAIN_AUX_D,

	POWER_DOMAIN_AUX_TC1 = POWER_DOMAIN_AUX_D,

	POWER_DOMAIN_AUX_E,

	POWER_DOMAIN_AUX_TC2 = POWER_DOMAIN_AUX_E,

	POWER_DOMAIN_AUX_F,

	POWER_DOMAIN_AUX_TC3 = POWER_DOMAIN_AUX_F,

	POWER_DOMAIN_AUX_TC4,

	POWER_DOMAIN_AUX_TC5,

	POWER_DOMAIN_AUX_TC6,

	POWER_DOMAIN_AUX_G,

	POWER_DOMAIN_AUX_H,

	POWER_DOMAIN_AUX_I,

	POWER_DOMAIN_AUX_IO_A,

	POWER_DOMAIN_AUX_TBT1,

	POWER_DOMAIN_AUX_TBT2,

	POWER_DOMAIN_AUX_TBT3,

	POWER_DOMAIN_AUX_TBT4,

	POWER_DOMAIN_AUX_TBT5,

	POWER_DOMAIN_AUX_TBT6,

	POWER_DOMAIN_AUX_C_TBT,

	POWER_DOMAIN_AUX_D_TBT,

	POWER_DOMAIN_AUX_E_TBT,

	POWER_DOMAIN_AUX_F_TBT,

	POWER_DOMAIN_AUX_G_TBT,

	POWER_DOMAIN_AUX_H_TBT,

	POWER_DOMAIN_AUX_I_TBT,

	POWER_DOMAIN_GMBUS,

	POWER_DOMAIN_MODESET,

	POWER_DOMAIN_GT_IRQ,
@@ -269,8 +258,7 @@ void intel_display_power_suspend(struct drm_i915_private *i915); 
void intel_display_power_resume(struct drm_i915_private *i915);



const char *

intel_display_power_domain_str(struct drm_i915_private *i915,

			       enum intel_display_power_domain domain);

intel_display_power_domain_str(enum intel_display_power_domain domain);



bool intel_display_power_is_enabled(struct drm_i915_private *dev_priv,

				    enum intel_display_power_domain domain);

drivers/gpu/drm/i915/i915_debugfs.c

+1 −2
Original line number Diff line number Diff line
@@ -2365,8 +2365,7 @@ static int i915_power_domain_info(struct seq_file *m, void *unused) 


		for_each_power_domain(power_domain, power_well->desc->domains)

			seq_printf(m, "  %-23s %d\n",

				 intel_display_power_domain_str(dev_priv,

								power_domain),

				 intel_display_power_domain_str(power_domain),

				 power_domains->domain_use_count[power_domain]);

	}

CRA Git | Maintained and supported by SUSTech CRA and CCSE