Commit 8a455b08 authored Mar 20, 2008 by Jarek Poplawski Committed by David S. Miller Mar 20, 2008

netpoll: zap_completion_queue: adjust skb->users counter



zap_completion_queue() retrieves skbs from completion_queue where they have
zero skb->users counter.  Before dev_kfree_skb_any() it should be non-zero
yet, so it's increased now.

Reported-and-tested-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Jarek Poplawski <jarkao2@gmail.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 2bec008c

net/core/netpoll.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -215,12 +215,14 @@ static void zap_completion_queue(void)
		while (clist != NULL) {
		struct sk_buff *skb = clist;
		clist = clist->next;
		if (skb->destructor)
		if (skb->destructor) {
		atomic_inc(&skb->users);
		dev_kfree_skb_any(skb); /* put this one back */
		else
		} else {
		__kfree_skb(skb);
		}
		}
		}

		put_cpu_var(softnet_data);
		}

Admin message